Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1950 closed defect (fixed)

Browse mode in LiveTV partly broken

Reported by: g8ecj@… Owned by: danielk
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

For the last month or so (exact version of breakage not known & I have no test system to be able to wind back my database to a previous version) the LiveTV Browse mode has allowed up/down to get the EPG info for the next/previous channel but the left/right usage to gte the next/previous timeslot is broken, returning a program of 0 minutes long and no info. Once into this state, the only way out is up/down/escape (i.e. right gets the bad Browse info, left does NOT restore the current time/channel info).

Thought I'd raise a ticket (since there is no open one) in case it drops through the gaps from now to 0.20 :-)

Attachments (1)

tv_rec.cpp.patch (802 bytes) - added by mythtv@… 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by james.muscat@…

I have the same problem. The only discernable error output is

"QDateTime::fromString: Parameter out of range"

and this occurs three times with every right/left keypress.

Changed 13 years ago by mythtv@…

Attachment: tv_rec.cpp.patch added

comment:2 Changed 13 years ago by mythtv@…

The attached file fixes this problem, which was introduced in changeset [9944], if I my quick look did not fool me.

take care, have fun /christian

comment:3 Changed 13 years ago by danielk

Owner: changed from Isaac Richards to danielk

comment:4 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [10258]) Closes #1950. Fixes browse mode for time changes using modified patch from Christian Hoenig.

The problem was that the chanid wasn't being initialized for browse left and browse right.

This also removes some redundancies in the DB queries, uses bindValue() where possible, adds DB error reporting, and resets all the data on DB failures.

comment:5 Changed 13 years ago by danielk

(In [10259]) Refs #1950. Additional LiveTV browse mode fixes.

  • Adds caching of TimeFormat? and ShortDateFormat? DB settings, so we don't query this on every GetNextProgram?() call.
  • Checks for blank starttime and endtime values before using QDateTime::fromString() to avoid spurious "QDateTime::fromString: Parameter out of range" error messages.
  • Checks validity of dbstarttime before using it to set browsestarttime, this prevents browsing in time on a channel when there is no listings information.
  • If there is no starttime (because there is no listings information) we use the current time for reporting the program start time.
Note: See TracTickets for help on using tickets.