Opened 13 years ago

Closed 13 years ago

#1955 closed patch (fixed)

Add missing theme components for mythgallery (fixes segault)

Reported by: sphery <mtdean@…> Owned by: danielk
Priority: minor Milestone: 0.20
Component: mythgallery Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch adds the missing submenu container to the gallery-ui.xml in the Minimalist-wide and Titivillus themes. As mentioned by Aaron McCarthy ( http://www.gossamer-threads.com/lists/mythtv/users/201240#201240 ), these changes should have been in the patch on #603 that was committed in [9458].

Without the changes, users who have selected either the Minimalist-wide or Titivillus theme will get a frontend segfault when they attempt to enter MythGallery.

Attachments (1)

myththemes-mythgallery-segfault_in_themes.patch (2.3 KB) - added by sphery <mtdean@…> 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by sphery <mtdean@…>

comment:1 Changed 13 years ago by danielk

Milestone: 0.20
Owner: changed from Isaac Richards to danielk
Version: head

comment:2 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [10215]) Closes #1955, Refs #603. Adds custom submenu container for Minimalist-wide and Titivillus gallery-ui definitions.

comment:3 Changed 13 years ago by drdaz

Resolution: fixed
Status: closedreopened

This problem seems to still be present using the MythCenter?-wide theme.

comment:4 Changed 13 years ago by sphery <mtdean@…>

MythCenter?-wide does not have a gallery-ui.xml. It uses the one from default-wide. The gallery-ui.xml in default-wide /does/ specify a custom submenu. Entering MythGallery with MythCenter?-wide as the theme works for me (no segfault).

However, the menu container is not large enough to hold both the menu and the submenu, so the submenu is never visible. Because this is a different problem, I opened a new ticket (#2291).

comment:5 Changed 13 years ago by drdaz

Ahh... Must be something fishy on my end then. I copied the gallery-ui.xml file from default-wide to MythCenter?-wide and now I get no segfault. But as you say, the menu is too narrow.

comment:6 Changed 13 years ago by Anduin Withers

Resolution: fixed
Status: reopenedclosed

See #2291

Note: See TracTickets for help on using tickets.