Opened 14 years ago

Closed 14 years ago

#1957 closed patch (fixed)

Inconsitently capitalised program titles result in episodes orphaned from titles in PlaybackBox::FillList()

Reported by: charlton.duncan@… Owned by: Robert Tsai
Priority: trivial Milestone: unknown
Component: mythtv Version:
Severity: low Keywords:
Cc: Ticket locked: no

Description

This is not per se a bug in PlaybackBox? but the attached patch provides mitigation in the case of inconsistent guide data.

Example

The BBC recently broadcast a 3 part series called 'The Line of Beauty'. The titles for the episodes were inconsistently capitalised in the guide data - two episodes were billed as 'The Line of Beauty' and one as 'The Line Of Beauty'. All three episodes appeared in the 'All Programs' list in the PlaybackBox? but only two appeared under the title 'The Line of Beauty'. The third episode was orphaned and did not appear under any title.

Patch

A patch is attached that fixes the problem in the VIEW_TITLES case. It does not, by intention, fix similar situations in the VIEW_RECGROUPS and VIEW_CATEGORIES cases. Propogation of the fix to those cases is, I think, trivial and I will be pleased to do so if it is felt to be appropriate (I am not presently convinced that it is).

The patch, hopefully, gives most gain for least pain. The result in the case of inconsistent captilisation is probably the desired behaviour. There is a similar case which occurs with, for example, programs titled 'Foobar' and 'The Foobar' - this patch prevents one of those from becoming orphaned but the the behaviour in that case may not be ideal.

Attachments (1)

pbb-orphan.diff (854 bytes) - added by charlton.duncan@… 14 years ago.
Patch

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by charlton.duncan@…

Attachment: pbb-orphan.diff added

Patch

comment:1 Changed 14 years ago by Robert Tsai

Owner: changed from Isaac Richards to Robert Tsai
Type: defectpatch

comment:2 Changed 14 years ago by Robert Tsai

Resolution: fixed
Status: newclosed

(In [10274]) Merge [10273] from branches/commdetector2 (accidentally submitted from wrong workarea).

Closes #1957.

Apply patch from charton duncan at gmail dot com .

Key progLists QMap on normalized sort title rather than guide-info title, to deal with inconsistently-capitalized guide information.

Note: See TracTickets for help on using tickets.