Opened 14 years ago

Closed 14 years ago

#197 closed enhancement (fixed)

Horizontal Alignment of items in a MythListButton

Reported by: mfgalizi@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Attached are two patches and two source files. The first patch allows button lists to allign their items horizontally (in the new UI). The second is a changes mythuitest to show both the horizontal and vertical lists on the same screen. The attached source files need to be added into the mythuitest directory if you would like to see the horizontal list test.

Select toggles between lists, left/right and up/down move between horizontally and vertically alligned items (respectively).

The only problem with this as it is is that when changing between button lists, the out of focus list never dims. I'm not sure if that should be part of the widget or not.

Attachments (14)

horizontal_list.diff (7.6 KB) - added by mfgalizi@… 14 years ago.
Add horizontal allignment of button lists
test_hlists.diff (1.1 KB) - added by mfgalizi@… 14 years ago.
Patch mythuitest to show horizontal lists.
btnlisttest.cpp (3.6 KB) - added by mfgalizi@… 14 years ago.
Screen to show lists.
btnlisttest.h (610 bytes) - added by mfgalizi@… 14 years ago.
Screen to show lists.
horiz_list_and_gradient.diff.gz (3.8 KB) - added by mfgalizi@… 14 years ago.
Same as the previous patch, but gradients are moved to mythimage.
horiz_list_and_gradient_2.diff (15.8 KB) - added by mfgalizi@… 14 years ago.
Same as the previous patch, but locking in the gradient method
horiz_list_and_gradient_3.diff (15.8 KB) - added by mfgalizi@… 14 years ago.
This is what patch 2 was supposed to do
lb-ltarrow-reg.png (655 bytes) - added by mfgalizi@… 14 years ago.
list button left arrow (regular)
lb-ltarrow-sel.png (702 bytes) - added by mfgalizi@… 14 years ago.
list button left arrow (selected)
lb-rtarrow-reg.png (637 bytes) - added by mfgalizi@… 14 years ago.
list button left arrow (selected)
lb-rtarrow-sel.png (688 bytes) - added by mfgalizi@… 14 years ago.
list button left arrow (selected)
subclass_horiz_list_and_gradient.diff (17.3 KB) - added by mfgalizi@… 14 years ago.
This is functionally the same as the previous patch, but the horizontal list is a subclass of the vertical.
btnlisttest.2.cpp (3.8 KB) - added by mfgalizi@… 14 years ago.
Updated for the subclassed version of the horizontal list.
btnlisttest.2.h (610 bytes) - added by mfgalizi@… 14 years ago.
Updated for the subclassed version of the horizontal list.

Download all attachments as: .zip

Change History (19)

Changed 14 years ago by mfgalizi@…

Attachment: horizontal_list.diff added

Add horizontal allignment of button lists

Changed 14 years ago by mfgalizi@…

Attachment: test_hlists.diff added

Patch mythuitest to show horizontal lists.

Changed 14 years ago by mfgalizi@…

Attachment: btnlisttest.cpp added

Screen to show lists.

Changed 14 years ago by mfgalizi@…

Attachment: btnlisttest.h added

Screen to show lists.

comment:1 Changed 14 years ago by Isaac Richards

Looks good, but I think it could be implemented a little cleaner if were a new class that inherited from the MythListButton? class and just reimplemented a few key functions.

Changed 14 years ago by mfgalizi@…

Same as the previous patch, but gradients are moved to mythimage.

Changed 14 years ago by mfgalizi@…

Same as the previous patch, but locking in the gradient method

comment:2 Changed 14 years ago by anonymous

Horizontal allignment still needs to be setup as a subclass (superclass would be verticle) and when the new theming code is added, I can add allignment and arrow button properties.

comment:3 Changed 14 years ago by mfgalizi@…

Please ignore that patch... I goofed.

Changed 14 years ago by mfgalizi@…

This is what patch 2 was supposed to do

Changed 14 years ago by mfgalizi@…

Attachment: lb-ltarrow-reg.png added

list button left arrow (regular)

Changed 14 years ago by mfgalizi@…

Attachment: lb-ltarrow-sel.png added

list button left arrow (selected)

Changed 14 years ago by mfgalizi@…

Attachment: lb-rtarrow-reg.png added

list button left arrow (selected)

Changed 14 years ago by mfgalizi@…

Attachment: lb-rtarrow-sel.png added

list button left arrow (selected)

Changed 14 years ago by mfgalizi@…

This is functionally the same as the previous patch, but the horizontal list is a subclass of the vertical.

Changed 14 years ago by mfgalizi@…

Attachment: btnlisttest.2.cpp added

Updated for the subclassed version of the horizontal list.

Changed 14 years ago by mfgalizi@…

Attachment: btnlisttest.2.h added

Updated for the subclassed version of the horizontal list.

comment:4 Changed 14 years ago by mfgalizi@…

After applying the most recent patch, button lists will be ready to have thier allignment specified in the theme (once the theme code is setup).

comment:5 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [7139]) Closes #197.

Patch from mfgalizi to add a horizontal button list type. Made it simpler, a bit, too.

Note: See TracTickets for help on using tickets.