Opened 13 years ago

Closed 13 years ago

#2013 closed patch (fixed)

Fix changing channels with leading zeros

Reported by: russell@… Owned by: danielk
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

For some reason, the existing code to handle the case where a user enters zeros before the channel number is not working correctly. I have replaced it with a slightly simpler method that makes it work again. I can now happily change to channel "6" by entering "06". :)

The last hunk of this patch just removes an unused variable.

Attachments (1)

channel_zeros_prefix.patch (2.1 KB) - added by russell@… 13 years ago.
patch to fix changing channels with leading zeros

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by russell@…

Attachment: channel_zeros_prefix.patch added

patch to fix changing channels with leading zeros

comment:1 Changed 13 years ago by russell@…

I am also available on IRC as "russellb".

comment:2 Changed 13 years ago by anonymous

Version: head

comment:3 Changed 13 years ago by danielk

Milestone: 0.20
Owner: changed from Isaac Richards to danielk

comment:4 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [10482]) Fixes #2013. Allow user to enter multiple leading zeros in "dumb" channel change.

When optimizing the regular expressions for the slow regular expression matcher on Mac OS X, we made the leading zero regular expression non-greedy. This meant it only eliminated the first of the zeros entered each time GetQueuedChanNum?() was called. When smart channel changing is disabled GetQueuedChanNum?() was not called on each character entered so only some of the leading zeros were removed.

This implements the original regular expression manually.

Note: See TracTickets for help on using tickets.