Opened 18 years ago
Closed 18 years ago
#2013 closed patch (fixed)
Fix changing channels with leading zeros
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.20 |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
For some reason, the existing code to handle the case where a user enters zeros before the channel number is not working correctly. I have replaced it with a slightly simpler method that makes it work again. I can now happily change to channel "6" by entering "06". :)
The last hunk of this patch just removes an unused variable.
Attachments (1)
Change History (5)
Changed 18 years ago by
Attachment: | channel_zeros_prefix.patch added |
---|
comment:2 Changed 18 years ago by
Version: | → head |
---|
comment:3 Changed 18 years ago by
Milestone: | → 0.20 |
---|---|
Owner: | changed from Isaac Richards to danielk |
comment:4 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [10482]) Fixes #2013. Allow user to enter multiple leading zeros in "dumb" channel change.
When optimizing the regular expressions for the slow regular expression matcher on Mac OS X, we made the leading zero regular expression non-greedy. This meant it only eliminated the first of the zeros entered each time GetQueuedChanNum?() was called. When smart channel changing is disabled GetQueuedChanNum?() was not called on each character entered so only some of the leading zeros were removed.
This implements the original regular expression manually.
patch to fix changing channels with leading zeros