Opened 13 years ago

Closed 13 years ago

#2044 closed enhancement (fixed)

add support for v4l2 mpeg encoding api

Reported by: Janne <janne-mythtv@…> Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: 0.20
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Attached patch implements the new V4L2 mpeg encoding api in MPEGRecorder. The API is added to the upcoming kernel 2.6.18.

Supported cards will be ivtv release 0.8 and in kernel drivers for pvr2usb and cx88-blackbird.

I'm not sure if the vbi support is working since current ivtv has no vbi support.

Hans Verkuil looked at the patch and said it is ok.

Attachments (4)

v4l2_mpeg.diff​ (31.7 KB) - added by Janne <janne-mythtv@…> 13 years ago.
v4l2_mpeg.2.diff​ (32.3 KB) - added by Janne <janne-mythtv@…> 13 years ago.
v4l2_mpeg_64bit_and_audio_fix.diff​ (1.7 KB) - added by Janne <janne-mythtv@…> 13 years ago.
sync_myth_videodev2_with_kernel.diff​ (356 bytes) - added by Janne <janne-mythtv@…> 13 years ago.

Download all attachments as: .zip

Change History (11)

Changed 13 years ago by Janne <janne-mythtv@…>

Attachment: v4l2_mpeg.diff​ added

comment:1 Changed 13 years ago by danielk

Milestone: → 0.20
Owner: changed from Isaac Richards to danielk

comment:2 Changed 13 years ago by danielk

Resolution: → invalid
Status: new → closed

Can you look this over again?

  • parts of the patch are missing ( header file[s] ? )
  • exceeds 80 columns
  • unneeded whitespace changes

comment:3 Changed 13 years ago by Janne <janne-mythtv@…>

Resolution: invalid
Status: closed → reopened

ah, sorry about that. fixed patch attached.

I haven't fixed the whitespace changes in videodev2_myth.h since I'm unsure how the file should be handled. The diff for this file was generated by: 

diff -u linux-2.6.15/**/videodev2.h linux-2.6.18-rc1/**/videodev2.h | patch -pRightValue

I can strip the whitespace changes. But I think it is better to stay in sync with the kernel header.

Changed 13 years ago by Janne <janne-mythtv@…>

Attachment: v4l2_mpeg.2.diff​ added

comment:4 Changed 13 years ago by danielk

Resolution: → fixed
Status: reopened → closed

(In [10589]) Fixes #2044. Start getting MythTV ready for in kernel ivtv driver in Linux 2.6.18 with patch from Janne.

Unless ivtv releases a fixed driver for 2.6.18, the upcoming Linux 2.6.18 release should not be used by those wishing to have fully functional PVR-250 or PVR-350 support, the ivtv driver has not yet been completely ported to the new interface. In particular aspect ratio info, captions and teletext will not be recorded when using the in kernel 2.6.18 ivtv driver.

Changed 13 years ago by Janne <janne-mythtv@…>

Attachment: v4l2_mpeg_64bit_and_audio_fix.diff​ added

comment:5 Changed 13 years ago by Janne <janne-mythtv@…>

Milestone: 0.20
Resolution: fixed
Status: closed → reopened
Version: head → 0.20

A structure in videodev2.h was changed after my initial patch. This modification will also be in the upcoming 2.6.18 kernel version (initial release of V4L2 Mpeg encoding api). The attached patch fixes this 64bit only issue.

It also actually forces MPEG Layer 2 audio encoding and corrects a debug message.

Changed 13 years ago by Janne <janne-mythtv@…>

Attachment: sync_myth_videodev2_with_kernel.diff​ added

comment:6 Changed 13 years ago by Stuart Auchterlonie

(In [11273]) Refs #2044. Last minute change to the v4l2 api due in ivtv 0.8. Sync's with this change.

comment:7 Changed 13 years ago by Stuart Auchterlonie

Resolution: → fixed
Status: reopened → closed

(In [11274]) Closes #2044. Last minute change to the v4l2 API due for release with ivtv 0.8. Sync with this change.

Note: See TracTickets for help on using tickets.