Opened 13 years ago

Closed 13 years ago

#2051 closed defect (fixed)

DVB EIT update updates wrong airdate values

Reported by: otto at kolsi dot fi Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

With SVN 10490, DVB-T, FC4, mysql-4.1.20-1.FC4.1:

When EIT info is updated to DB, airdate column gets skrewed. Below is one example of the update query where airdate column is updated with value '0'. When you update it like this, it actually gets value '2000'. Proper value to be used in update is '0000' which is used e.g. in DBEvent::UpdateDB(MSqlQuery &query, const DBEvent &match) in eit.cpp.

At least one place where this failure occurs is that same function. lairdate seems to be empty and match.airdate not -> match.airdate is used in update and it probably is not properly initialized, contains value '0' or something like that.

2006-07-13 20:42:07.255 MSqlQuery: UPDATE program SET title = 'Kesäillan valssi',
subtitle = '', description = 'Perinteiset tanssiaiset Seinäjoen Tangomarkkinoilta.
 Solistivieraana Topi Sorsakoski ja säestävänä orkesterina Varjokuva. Mukana
 myös uusi SM-voittaja Nelinpeli. Juontajina Sari Tamminen ja Kyösti Mäkimattila,
 tangon askeleet opetta', category = 'Show/game Show', category_type = 'tvshow',
 starttime = '2006-07-13T21:00:00', endtime = '2006-07-13T21:46:49', closecaptioned
 = 0, subtitled = 1,stereo = 1, hdtv = 0, partnumber = 0, parttotal = 0, airdate      
 = '0', originalairdate=NULL, listingsource = 1 WHERE chanid = 1033 AND starttime =
 '2006-07-13T21:00:00'

Attachments (1)

eit_airdate_fix.diff (572 bytes) - added by otto at kolsi dot fi 13 years ago.
Fix for airdate problem

Download all attachments as: .zip

Change History (8)

comment:1 Changed 13 years ago by danielk

Component: dvbmythtv
Milestone: 0.20
Owner: changed from danielk to Isaac Richards

comment:2 Changed 13 years ago by danielk

Owner: changed from Isaac Richards to Stuart Auchterlonie

comment:3 Changed 13 years ago by otto at kolsi dot fi

Other symptoms:

  • EIT data contains program info with either very old or future dates (years like 1902 or 2037)
  • some programs get insufficient descriptions (descriptions are too short, end is missing).

comment:4 Changed 13 years ago by danielk

Milestone: 0.200.21

If you can make a patch for this in the next couple days I'll apply it in time for 0.20.

comment:5 Changed 13 years ago by otto at kolsi dot fi

Attached 'eit_airdate_fix.diff' patch fixes the airdate problem.

EIT data inserts to DB are okay, but when existing data is updated, match.airdate gets value '0' and when this is again updated back to DB -> airdate column gets value '2000'.

Changed 13 years ago by otto at kolsi dot fi

Attachment: eit_airdate_fix.diff added

Fix for airdate problem

comment:6 Changed 13 years ago by Stuart Auchterlonie

Milestone: 0.210.20
Status: newassigned

comment:7 Changed 13 years ago by Stuart Auchterlonie

Resolution: fixed
Status: assignedclosed

(In [10697]) Closes #2051. Fixes incorrect EIT airdate updates

Don't update the airdate with the EIT data if the airdate is '0' aka 2000.

Note: See TracTickets for help on using tickets.