Opened 13 years ago

Closed 13 years ago

#2054 closed defect (fixed)

mythuitext.cpp does not store m_OrigDisplayRect when parsing from xml

Reported by: adaniels Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When parsing a MythUIText type from xml, the m_OrigDisplayRect is not stored. This allows for UseAlternateArea?(true), but shifting to the original area with UseAlternateArea?(false) fails.

A patch is included that corrects the issue.

Attachments (5)

fix.patch (492 bytes) - added by adaniels 13 years ago.
Correctly stores a copy of m_Area in m_OrigDisplayRect
fix.2.patch (498 bytes) - added by adaniels 13 years ago.
Correctly stores a copy of m_Area in m_OrigDisplayRect (update: spaces instead of tabs)
fix.3.patch (506 bytes) - added by adaniels 13 years ago.
More elegant and appropriate solution given that we do not need to issue a redraw.
fix.4.patch (492 bytes) - added by adaniels 13 years ago.
More elegant and appropriate solution given that we do not need to issue a redraw. (update: removed curly brackets again)
fix.5.patch (489 bytes) - added by adaniels 13 years ago.
*sigh* I broke my own patch, but this should be last one =P

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by adaniels

Attachment: fix.patch added

Correctly stores a copy of m_Area in m_OrigDisplayRect

Changed 13 years ago by adaniels

Attachment: fix.2.patch added

Correctly stores a copy of m_Area in m_OrigDisplayRect (update: spaces instead of tabs)

Changed 13 years ago by adaniels

Attachment: fix.3.patch added

More elegant and appropriate solution given that we do not need to issue a redraw.

Changed 13 years ago by adaniels

Attachment: fix.4.patch added

More elegant and appropriate solution given that we do not need to issue a redraw. (update: removed curly brackets again)

Changed 13 years ago by adaniels

Attachment: fix.5.patch added

*sigh* I broke my own patch, but this should be last one =P

comment:1 Changed 13 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

Was fixed last night.

Note: See TracTickets for help on using tickets.