Opened 18 years ago
Closed 18 years ago
#2109 closed patch (fixed)
AC3 passthru problems with OSS driver.
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
When using the nvidia supplied nvsound oss driver and a nForce2 ac3 passthru results in static. The audio device is being opend without checking audio_passthru and setting appropriate format in audiooutputoss.cpp. Attached patch checks if the sound card should be set for ac3(dts) passthru and sets format to be AFMT_AC3 overriding previous pcm format values.
Attachments (2)
Change History (11)
Changed 18 years ago by
Attachment: | oss_spdif_patch.diff added |
---|
comment:1 Changed 18 years ago by
Milestone: | → unknown |
---|---|
Owner: | changed from Isaac Richards to danielk |
Severity: | medium → low |
Version: | → head |
comment:2 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 18 years ago by
Milestone: | unknown → 0.20 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
These changes cause breakage for other users. See the thread
http://mythtv.org/pipermail/mythtv-dev/2006-August/049669.html
comment:4 Changed 18 years ago by
comment:5 Changed 18 years ago by
Milestone: | 0.20 → 0.21 |
---|
comment:6 Changed 18 years ago by
Resolution: | → invalid |
---|---|
Status: | reopened → closed |
closing, this patch causes problems for other hardware.
comment:7 Changed 18 years ago by
Whoops, forgot about this, I cleaned up the patch some, it may fix the problem that was seen earlier. This should work exactly like mplayer now.
Changed 18 years ago by
Attachment: | oss_spdif_patch2.diff added |
---|
comment:8 Changed 18 years ago by
Resolution: | invalid |
---|---|
Status: | closed → reopened |
comment:9 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [11392]) Fixes #2109. Adds support for AC3 passthrough audio with OSS drivers.
This sets the format flag appropriately, since many filters & decoders don't detect digital data robustly.
In addition to the code that was added in [10718] and reverted in [10762] this adds a sanity check to make sure the drivers support AC3 passthrough before setting the passthrough bit. Some drivers support AC3 passthough, but don't support the official OSS API for it and die a horrible death when you set the AC3 bit.
OSS ac3 passthru patch