Opened 13 years ago

Closed 13 years ago

#2121 closed defect (fixed)

Changeset:10547 breaks realtime commercial flagging

Reported by: anonymous Owned by: cpinkham
Priority: minor Milestone: 0.20
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

After upgrading from svn10408 to svn10675 realtime commflagging (logo detection) no longer works. The result shown on MythTV status is always "Finished, 0 break(s) found". Commercials are correctly detected if I run mythcommflag manually from the command line.

If I run svn10675 with changeset:10547 revertet, everything works as expected.

The attached file mythbackend.log contains the output from the mythbackend log during a realtime flagging (-v commflag). No commercial breaks are detected.

The file mythcommflag.txt contains the output from "mythcommflag -v commflag --nopercentage ..." run from the command line. 3 breaks are detected.

Attachments (6)

mythbackend.log (4.7 KB) - added by anonymous 13 years ago.
realtime flagging log
mythcommflag.txt (9.6 KB) - added by anonymous 13 years ago.
output from mythcommflag run from the command line
commdetectordebug.diff (1.9 KB) - added by cpinkham 13 years ago.
Patch to print out some debug values for the ClassicCommDetector?
debug.log (16.5 KB) - added by anonymous 13 years ago.
mythbackend d
lucaspatch1 (887 bytes) - added by lucas@… 13 years ago.
patch that might solve the problem.
lucaspatch2 (1.1 KB) - added by lucas@… 13 years ago.

Download all attachments as: .zip

Change History (15)

Changed 13 years ago by anonymous

Attachment: mythbackend.log added

realtime flagging log

Changed 13 years ago by anonymous

Attachment: mythcommflag.txt added

output from mythcommflag run from the command line

Changed 13 years ago by cpinkham

Attachment: commdetectordebug.diff added

Patch to print out some debug values for the ClassicCommDetector?

comment:1 Changed 13 years ago by cpinkham

Milestone: 0.20
Status: newassigned

Please apply the attached commdetectordebug.diff patch and attach the mythbackend logs from when it tries realtime flagging. I'm running 10663 here and it seems to be working fine, I don't see any cases in my logs where my flagging failed. It looks like the flagger is getting stuck in the loop where it waits for the logo detection buffer to build up, and then when the recording finishes it thinks it didn't have enough buffer to run detection so it returns 0 breaks found. The attached debug patch will help me see if that is occurring and help me figure out what is going on.

Changed 13 years ago by anonymous

Attachment: debug.log added

mythbackend d

comment:2 Changed 13 years ago by anonymous

Log attached. Still using svn 10675.

comment:3 Changed 13 years ago by lucas@…

Would you be so kind to attach the output of a non-realtime mythcommflag session on the same file? It looks like the logo detection isn't doing anything at all.

comment:4 Changed 13 years ago by lucas@…

Owner: changed from cpinkham to lucas
Status: assignednew

please try the attached patch. You should be able to see if it works or not within +- 500 seconds. Once your logs say: "Searching for station logo", you're probably okay. If it doesn't work, could you send a log of the first 700 orso seconds? thanks.

Changed 13 years ago by lucas@…

Attachment: lucaspatch1 added

patch that might solve the problem.

comment:5 Changed 13 years ago by anonymous

Yup, the lucaspatch1 patch seems to fix it. Thanks.

comment:6 Changed 13 years ago by lucas@…

Owner: changed from lucas to anonymous
Status: newassigned

Great. I'd like to ask you to apply lucaspatch2, and send me the logs for the first 600 seconds orso of your live recording. The check that lucaspatch1 comments out was not needed anymore imho, but I'd still like to know why it fails, because it shouldn't, so maybe there's another problem involved here. (unapply lucaspatch1 first).

Changed 13 years ago by lucas@…

Attachment: lucaspatch2 added

comment:7 Changed 13 years ago by Isaac Richards

Owner: changed from anonymous to cpinkham
Status: assignednew

comment:8 Changed 13 years ago by anonymous

Log with lucaspatch2:

2006-08-07 14:39:51.780 TVRec(1): Changing from None to RecordingOnly
2006-08-07 14:39:51.812 TVRec(1): HW Tuner: 1->1
2006-08-07 14:39:52.074 Started recording: Smallville "Sacred": channel 1003 on cardid 1, sourceid 1
QDateTime::fromString: Parameter out of range
2006-08-07 14:40:38.312 JobQueue: Commercial Flagging Starting for Smallville "Sacred" recorded from channel 1003 at Mon Aug 7 14:40:00 2006
2006-08-07 14:40:38.654 Using runtime prefix = /usr
2006-08-07 14:40:38.697 New DB connection, total: 1
2006-08-07 14:40:38.721 Connected to database 'mythconverg' at host: localhost
2006-08-07 14:40:38.733 New DB connection, total: 2
2006-08-07 14:40:38.735 Connected to database 'mythconverg' at host: localhost
2006-08-07 14:40:38.763 Connecting to backend server: 127.0.0.1:6543 (try 1 of 5)
2006-08-07 14:40:38.766 Using protocol version 30
2006-08-07 14:40:38.770 MainServer::HandleAnnounce Monitor
2006-08-07 14:40:38.771 adding: lithium as a client (events: 0)
2006-08-07 14:40:38.786 MainServer::HandleAnnounce Monitor
2006-08-07 14:40:38.810 adding: lithium as a client (events: 1)
2006-08-07 14:40:38.823 mythcommflag will flag recording currently in progress on cardid 1
2006-08-07 14:40:38.847 mythcommflag processing JobID 1461
2006-08-07 14:40:38.850 mythcommflag sending COMMFLAG_START notification
0: start_time: 0.036 duration: 4.043
1: start_time: 0.025 duration: 4.015
stream: start_time: 0.276 duration: 45.044 bitrate=3625 kb/s
2006-08-07 14:40:38.878 AFD: Opened codec 0x812c7b0, id(MPEG2VIDEO) type(Video)
2006-08-07 14:40:38.903 AFD: Opened codec 0x812cbb0, id(MP2) type(Audio)
2006-08-07 14:40:38.915 Commercial Detection initialized: width = 720, height = 576, fps = 25, method = 4
2006-08-07 14:40:38.916 Using Sample Spacing of 6 horizontal & 6 vertical pixels.
2006-08-07 14:40:38.918 CommDetect::ClearAllMaps()
2006-08-07 14:40:38.942 mythcommflag: Received Event: 'COMMFLAG_START 1003 2006-08-07T14:40:00'
2006-08-07 14:48:31.358 Made it past short recordings check
2006-08-07 14:48:31.361 nvp->GetLength() returns:  41
2006-08-07 14:48:31.362 logo->getRequiredAvailableBufferForSearch() returns: 480
2006-08-07 14:48:31.464 Searching for Station Logo
2006-08-07 14:48:31.465 Trying with edgeDiff == 5

comment:9 Changed 13 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [10744]) Apply a patch from lucas to fix a bug created in [10547]. Closes #2121.

Note: See TracTickets for help on using tickets.