Opened 13 years ago

Closed 13 years ago

#2124 closed enhancement (fixed)

patch to add preserve flag to program info GUI

Reported by: rich@… Owned by: cpinkham
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Per my thread on the user list I created a patch that will put an icon on the program information box on the recorded program list when a program is flagged to be preserved from deletion (due to a series record set to auto-expire once a episode limit is reached).

Note that I first attempted to patch programinfo.cpp, which looks like it isn't used to retrieve the program info on this screen (not quite sure what it is for), although programinfo.h is clearly used to for the flag defines. I left it patched - delete this patch if it is inappropriate.

Attached are all the necessary patches and my stab in the dark at a .png that could be used for this icon. I did not attempt to patch every theme, although the process is fairly straightforward.

I'm curious to receive feedback regarding this potential contribution, and if I should open a ticket let me know.

Patches generated using svn diff against the latest svn build - they are different from the ones on the -dev list since those were against a 0.19 branch.

Attachments (3)

preservediff.diff (3.4 KB) - added by rich@… 13 years ago.
patch
preserve.png (1.3 KB) - added by rich@… 13 years ago.
suggested possible icon
2124-v1.patch (5.2 KB) - added by danielk 13 years ago.
cleaned up patch

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by rich@…

Attachment: preservediff.diff added

patch

Changed 13 years ago by rich@…

Attachment: preserve.png added

suggested possible icon

comment:1 Changed 13 years ago by danielk

Milestone: 0.21
Owner: changed from Isaac Richards to danielk
Severity: mediumlow
Type: defectenhancement
Version: head

Changed 13 years ago by danielk

Attachment: 2124-v1.patch added

cleaned up patch

comment:2 Changed 13 years ago by danielk

Owner: changed from danielk to gigem

David, I'm not sure whether this is something we really need a flag for.

I made the patch apply to [11404] and compile, but I'll leave it to your judgement whether to apply it.

comment:3 Changed 13 years ago by cpinkham

Owner: changed from gigem to cpinkham

Taking ownership of this after talking with Gigem.

comment:4 Changed 13 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [11455]) Add the ability to have a 'Preserved' flag icon on the Watch Recordings screen. This icon will show whenever a recording is preserved as long as the theme supports the preserved icon.

No themes are being modified with this patch because there already a large number of flag icons. An example of using the preserved flag is in the blue theme's ui.xml file. Theme designers can decide for themselves whether to use the preserved flag icon in their theme design. Users wanting to use the flag in an existing theme can user their own oopy of the theme ui.xml file.

Closes #2124 by applying most of patch submitted by Rich and updated by Daniel.

Note: See TracTickets for help on using tickets.