Opened 13 years ago

Closed 13 years ago

#2157 closed patch (fixed)

Commercial skip loses audio sync adjustments

Reported by: kkuphal Owned by: Isaac Richards
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When commercial skipping either manually or automatically, the frontend resets the audio sync adjustment to zero because the adjustment is not saved before resetting the audio. The attach patch, I believe, fixes this. Not being intimately familiar with the code, I offer it here rather than simply commiting the fix.

Attachments (1)

retain-audio-sync.diff (761 bytes) - added by kkuphal 13 years ago.

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by kkuphal

Attachment: retain-audio-sync.diff added

comment:1 Changed 13 years ago by Isaac Richards

Kevin, I'm not sure if that's correct. It looks like it'd be giving different numbers than the existing call to 'SaveAudioTimecodeOffset?' from the TV class when it does a seek, doesn't it?

comment:2 Changed 13 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [11026]) Apply patch from #2157 to retain manual a/v sync offsets better during a seek.

Didn't see any sideeffects when testing, but still could be some (possibly if the timestamps wrap normally..)

Closes #2157.

Note: See TracTickets for help on using tickets.