Opened 13 years ago

Closed 12 years ago

#2163 closed patch (fixed)

incorrect placement of edit marks

Reported by: Janne <janne-mythtv@…> Owned by: Janne Grunau
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: yes

Description

Edit marks with enabled overscan are incorrect placed since the OSDSet constructor has no knowledge of [xy]offset. They are correct after a OSD reinit. Atteched patch changes the constructor and and uses the new constructor in ShowEditArrow?.

The edit arraws image is not correctly scaled to PAL resulotion. After a Reinit() it is scaled. The Patch calls Reinit after creating a new edit arrow since I couldn't figure out where the image is scaled. I hope someone with more knowledge of the osd code can take a look at this issue and solve it correctly.

Attachments (3)

2163_fix_edit_osd_placement.diff (3.0 KB) - added by Janne <janne-mythtv@…> 13 years ago.
libmythtv patch for correct osd placement of cut marks
2163_fix_osd_themes.diff (10.0 KB) - added by Janne <janne-mythtv@…> 13 years ago.
changes to all osd.xml in svn
2163_updated_osd_images.tar.gz (4.8 KB) - added by Janne <janne-mythtv@…> 13 years ago.
updated osd images

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by Janne <janne-mythtv@…>

Edit marks are still displayed off with defaultosd and blueosd. Il update the patch.

Changed 13 years ago by Janne <janne-mythtv@…>

libmythtv patch for correct osd placement of cut marks

Changed 13 years ago by Janne <janne-mythtv@…>

Attachment: 2163_fix_osd_themes.diff added

changes to all osd.xml in svn

Changed 13 years ago by Janne <janne-mythtv@…>

updated osd images

comment:2 Changed 13 years ago by Janne <janne-mythtv@…>

Updated patch against libmythtv.
-fixed inconsistent rounding.
-displays the cut marks images centered at the computed position since some themes use shadows.

The themes handle the edit osd inconsistantly (I suspect each the developer worked around the bugs until it was correctly displayed).
Updated theme images and a patch for the osd.xmls attached

comment:3 Changed 13 years ago by Janne Grunau

Owner: changed from Isaac Richards to Janne Grunau

I

comment:4 Changed 13 years ago by Janne Grunau

Resolution: fixed
Status: newclosed

(In [12492]) Fixes #2163, corrects edit arrows placement in all themes

Adds (x|y)offset to OSDSet constructor (needed for overscan) Scales edit arrows images accordingly to the screen resolution since some edit arrows use shadows the center of the cut image lies at the cut point changed all cut images and osd.xml in all themes

comment:5 Changed 13 years ago by Janne Grunau

Milestone: 0.21

comment:6 Changed 12 years ago by karlheg@…

Resolution: fixed
Status: closedreopened

Please apply changeset #12492 to the 0.20.2 branch.

comment:7 Changed 12 years ago by Janne Grunau

Resolution: fixed
Status: reopenedclosed
Ticket locked: set
Note: See TracTickets for help on using tickets.