Opened 14 years ago
Closed 13 years ago
#2187 closed task (fixed)
libmythtv/* have too many FOURCC definitions
Reported by: | Nigel | Owned by: | Nigel |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description (last modified by )
While fixing a Mac OS X compile bug, I happened to do:
egrep -i 'fourcc|MKTAG' *.{cpp,h}
in libmythtv. There are at least five source files where these Four Character Constants are defined. There are overlaps. MKTAG is redefined. This needs cleaning up!
I am thinking of creating libmythtv/fourcc.h with a sensible constant naming scheme, like FOURCC_IYUV
Change History (12)
comment:2 Changed 14 years ago by
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
comment:5 Changed 14 years ago by
comment:6 Changed 14 years ago by
Type: | defect → task |
---|
1) This is more of a code-review (i.e. task) than a defect.
2) I thought I would look at FFMPEG's code for direction. It also uses several different techniques, like;
be2me_32(ff_get_fourcc("mjpg")), MKBETAG('m','j','p','g'), MKTAG('m', 'j', 'p', 'b'), mmioFOURCC('Z','L','I','B')
3) I am still undecided if fourcc.h should have integer constants (fast to compile, but endian issues), or use macros (easy to read). Time to flip a coin?
comment:7 Changed 14 years ago by
comment:8 Changed 14 years ago by
Nigel,
You need to wrap the entire fourcc.h file in a conditional (#ifnef FOURCC_H ...) or the code won't compile.
comment:9 Changed 14 years ago by
comment:12 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
(In [10797]) Recent change, [10782], broke OS X compilation. util-xv.h was added to videobuffers.h for some constants, but util-xv.h won't compile on non-X-Windows environments. Time for a new place for the constants. See #2187