Opened 12 years ago

Closed 12 years ago

#2214 closed defect (fixed)

vbi device detection

Reported by: devel@… Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords: vbi device
Cc: Ticket locked: no

Description

vbi device detection code in videosource.cpp scans /dev/v4l and /v4l.

It should scan /dev/v4l and /dev instead.

Attachments (1)

v4l_vbi_device_detect.diff (877 bytes) - added by devel@… 12 years ago.
Patch to scan /dev instead of /v4l

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by devel@…

Attachment: v4l_vbi_device_detect.diff added

Patch to scan /dev instead of /v4l

comment:1 Changed 12 years ago by devel@…

Note: Attached patch also adds a check to remove symlinked devices. I get:
/dev/vbi (symlinked to default device - /dev/vbi0) /dev/vbi0

Only the vbiX devices are required.

comment:2 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [10886]) Fixes #2214. Checks for VBI devices in "/dev/v4l" and "/dev" not "/dev/v4l" and "/v4l".

I didn't apply the other change in the patch. I would rather see duplicate detection based on major and minor device numbers, like we do with video devices. Checking for symlinks is too fragile.

Note: See TracTickets for help on using tickets.