Opened 14 years ago

Closed 14 years ago

#2225 closed patch (fixed)

UTF-8 support in external text-based subtitle file for the internal video player

Reported by: jlagop -- jlagop A T gmail.com -- Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords: external subtitle files
Cc: Ticket locked: no

Description

In [10067], Fixing #1748, external subtitle file support for internal video player was added. However, when subtitles in the file are in UTF-8, with some accents or other characters(ñ,Ñ,¿,¡,etc), strange symbols are displayed on screen.

Attachments (1)

ext_subtitle_file_fixes.patch (3.4 KB) - added by Pekka Jääskeläinen <pekka.jaaskelainen@…> 14 years ago.
fix

Download all attachments as: .zip

Change History (6)

comment:1 Changed 14 years ago by jlagop -- jlagop A T gmail.com --

Maybe I can help on solvind this issue, if some help on where to start looking is given (fontname? QString issues?... Sorry, no much knowledge about myth coding). Thanks.

comment:2 Changed 14 years ago by anonymous

Milestone: 0.20

Changed 14 years ago by Pekka Jääskeläinen <pekka.jaaskelainen@…>

fix

comment:3 Changed 14 years ago by Pekka Jääskeläinen <pekka.jaaskelainen@…>

Milestone: 0.20

I attached a patch. I'd like to get this in before a release as this is a major hindrance for people using UTF8 sub files.

Improvements and fixes to the external (text) subtitle file support:

  • Fix printing the loaded subtitle file to the log.
  • Fix loading of UTF8 subs: detect if the strings cannot be presented as valid UTF8 chars and fall back to Latin1 in that case (TODO: add user option to select the fall back encoding, as it's not possible to reliably detect the 8-bit encoding)

comment:4 Changed 14 years ago by Isaac Richards

Milestone: 0.20

comment:5 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [11059]) Utf8 fixes for the external subtitle parser.

Closes #2225.

Note: See TracTickets for help on using tickets.