Opened 16 years ago
Closed 15 years ago
#226 closed defect (invalid)
Full screen playback when GUI size is smaller
Reported by: | ananthar at cs dot berkeley dot edu | Owned by: | Isaac Richards |
---|---|---|---|
Priority: | minor | Milestone: | 0.19 |
Component: | mythtv | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
When GUI size is smaller, but "Use GUI size for playback" is unchecked in settings, watching LiveTV starts at full-screen like it should.
But entering and exitting the EPG once breaks this. Playback remains at GUI size till LiveTV is restarted.
This small change fixes the problem.
Index: libs/libmythtv/tv_play.cpp =================================================================== --- libs/libmythtv/tv_play.cpp (revision 7064) +++ libs/libmythtv/tv_play.cpp (working copy) @@ -3458,12 +3458,11 @@ if (fullscreen) { - int xbase, ybase, screenwidth, screenheight; - float wmult, hmult; - gContext->GetScreenSettings(xbase, screenwidth, wmult, - ybase, screenheight, hmult); - mwnd->setGeometry(xbase, ybase, screenwidth, screenheight); - mwnd->setFixedSize(QSize(screenwidth, screenheight)); + DisplayRes *display_res = DisplayRes::GetDisplayRes(); + int maxWidth = display_res->GetMaxWidth(); + int maxHeight = display_res->GetMaxHeight(); + mwnd->setGeometry(0, 0, maxWidth, maxHeight); + mwnd->setFixedSize(QSize(maxWidth, maxHeight)); } menurunning = false;
Attachments (1)
Change History (4)
Changed 16 years ago by
Attachment: | tv_play_fullscreen.patch added |
---|
comment:1 Changed 16 years ago by
Milestone: | → 0.19 |
---|---|
Version: | → head |
comment:2 Changed 16 years ago by
I have tried to reproduce the problem (on the Mac OS X frontend) but it does not seem to manifest.
comment:3 Changed 15 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
Closing. No feedback from patch submitter about SEGFAULT the patch would cause.
Note: See
TracTickets for help on using
tickets.
This patch will cause a segfault when DisplayRes::GetDisplayRes?() returns NULL, and will fail in the presence of the Xinerama extensions.
Why not just query videooutbase for the current XJ_width & XJ_height?