Separate PCR pid (from Video) not recorded

[lpgcritter at nasquan dot com]

In Australia, most channels broadcast separate video/PCR pids. MythTV has logic for recording the PCR pid, but it fails because it never finds the TS Packet PayloadStart for the PCR pids, thus the PCR pids are not recorded on to the file.

My fix is to ignore the tspacket->PayloadStart?() condition for PCR pids.

Patch should be applied in libs/libmythtv

[danielk]

Please test against SVN head, a similar fix might be needed there as well.

[lpgcritter at nasquan dt com]

fix for trunk

[lpgcritter at nasquan dt com]

new fix for 0.19

[lpgcritter at nasquan dt com]

I've added a fix for trunk and a better fix for 0.19. It would be great if both could be applied in svn.

The root cause of the problem is that the PCR packets did not have payload and only the adaptation field. Because the code searches for payloadstart to begin writing and payloadstart field is never 1 for packets without payload, the pcr ts packets never get recorded. The patch adds a bypass for packets which don't have payload.

[Stuart Auchterlonie]

Due to the fact that 0.20 is in feature freeze I won't apply the 0.19 fixes, but will look at the patch for trunk for inclusion in 0.20

[Stuart Auchterlonie]

(In [11022]) Closes #2263. PCR packets don't have a payload so don't require a payload start in this situation.

[lpgcritter]

Looks like problem has returned with the new multirec stuff

[lpgcritter]

Fixes the problem for 0.21 - PCR packets have no payload

[lpgcritter]

better patch

[danielk]

(In [16876]) Fixes #2263. Write IsWritingPID's even if they don't have a payload; PCR streams do not...

[simon@…]

Can this patch be backported to 0.21-fixes? The bug it fixes renders a significant proportion of MythTV's DVB recordings unplayable in VLC.