Opened 15 years ago
Closed 13 years ago
Last modified 12 years ago
#2263 closed patch (fixed)
Separate PCR pid (from Video) not recorded
Reported by: | lpgcritter at nasquan dot com | Owned by: | Stuart Auchterlonie |
---|---|---|---|
Priority: | major | Milestone: | 0.20 |
Component: | dvb | Version: | 0.19 |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
In Australia, most channels broadcast separate video/PCR pids. MythTV has logic for recording the PCR pid, but it fails because it never finds the TS Packet PayloadStart for the PCR pids, thus the PCR pids are not recorded on to the file.
My fix is to ignore the tspacket->PayloadStart?() condition for PCR pids.
Patch should be applied in libs/libmythtv
Attachments (5)
Change History (12)
Changed 15 years ago by
Attachment: | mythtv-0.19-pcr-patch added |
---|
comment:1 Changed 15 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
comment:2 Changed 15 years ago by
Resolution: | invalid |
---|---|
Status: | closed → reopened |
I've added a fix for trunk and a better fix for 0.19. It would be great if both could be applied in svn.
The root cause of the problem is that the PCR packets did not have payload and only the adaptation field. Because the code searches for payloadstart to begin writing and payloadstart field is never 1 for packets without payload, the pcr ts packets never get recorded. The patch adds a bypass for packets which don't have payload.
comment:3 Changed 15 years ago by
Milestone: | 0.19.1 → 0.20 |
---|---|
Owner: | changed from danielk to Stuart Auchterlonie |
Status: | reopened → new |
Due to the fact that 0.20 is in feature freeze I won't apply the 0.19 fixes, but will look at the patch for trunk for inclusion in 0.20
comment:4 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:5 Changed 13 years ago by
Resolution: | fixed |
---|---|
Status: | closed → new |
Looks like problem has returned with the new multirec stuff
Changed 13 years ago by
Attachment: | mythtv-0.21.patch added |
---|
Fixes the problem for 0.21 - PCR packets have no payload
comment:6 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:7 Changed 12 years ago by
Can this patch be backported to 0.21-fixes? The bug it fixes renders a significant proportion of MythTV's DVB recordings unplayable in VLC.
Please test against SVN head, a similar fix might be needed there as well.