Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#2408 closed defect (fixed)

Favourite & channel no. in Browse mode broken

Reported by: g8ecj@… Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Sometime since about r11090 (I think thats the last working build I had) the Browse mode input of '0-9' (channel number) and '/' (favourite) stopped working.

Certainly not working on r11201!

If there have been no database schema changes since then, I'll do a binary chop on source to nail it down.

Change History (7)

comment:1 Changed 13 years ago by cpinkham

Nothing in the DB changed that would cause issues with going back and forth between those two revisions. If you can figure out what changeset caused the issue someone can look into it further.

comment:2 Changed 13 years ago by g8ecj@…

r11090 is OK for digit channel input in browse mode, gets broken by r11091.

I can't find a version that has the favourite key working, in either browse mode or just to select a channel - r11090 reselects the current channel instead of the favourite, r11091 does nothing with the '/' at all that I can see.

comment:3 Changed 13 years ago by gnome42@…

Hi,

You can try and see if this fixes digit channel input in browse mode. It doesn't fix the favourites though. :/

In tv_play.cpp, TV::BrowseChannel?(...)

@@ -5448,6 +5481,7 @@
         return;
 
     browsechannum = chan;
+    browsechanid = QString::null;
     BrowseDispInfo(BROWSE_SAME);
 }

comment:4 Changed 13 years ago by derek@…

I've applied the patch above and it fixes the digit input for browse mode.

comment:5 Changed 13 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham

comment:6 Changed 13 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [11354]) Fix favorite channels and direct channel number entry in browse mode.

Patch for direct channel entry by gnome42 at gmail.

Patch for favorites by me.

Closes #2408.

comment:7 Changed 13 years ago by cpinkham

(In [11355]) Carries over [11354] from trunk.

Fix favorite channels and direct channel number entry in browse mode.

References #2408.

Note: See TracTickets for help on using tickets.