Opened 14 years ago

Closed 14 years ago

#244 closed patch (fixed)

Jumpy audio and video due to unknown refresh rate

Reported by: benjie Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

For some reason the call to XF86VidModeGetModeLine() in videoout_xv.cpp returns a dot_clock value of 0 on my machine under ubuntu warty. This caused awefully jumpy video and audio.

I'm including a patch that checks for dot_clock==0, and then has it assume a 60hz refresh rate, since I think that's the most commonly used rate (does that sound right?). I'm on a laptop with a 50hz refresh, and assuming 60 here seems to work perfectly fine (just as well as using 50). It seems to work fine without being exact, as long as it's less than double, and more than half of the real rate.

Here's a small patch that fixes the issue on my machine: http://www.benjie.org/patches/refresh.diff

I know that assuming a fixed refresh rate on error is not ideal, but I think it's better than the current state of the code. I also have it print an error message so if it doesn't work for some people, it'll be easy to debug.

Change History (1)

comment:1 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [7181]) If we can't get the actual refresh rate, assume 60Hz. Closes #244.

Note: See TracTickets for help on using tickets.