Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2461 closed patch (fixed)

Mythfilldatabase fix removing existing and inserting same program and date format

Reported by: paulx@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: mythtv Version: 0.20
Severity: medium Keywords:
Cc: Ticket locked: no

Description

A few programs are repeatedly removed and added each time the same xmltv file is used. This is due to the comparison of two floats in the stars field.

http://dev.mysql.com/doc/refman/5.0/en/problems-with-float.html

Added the ORIGINALAIRDATE in the comparison with null handling.

Added some .utf8()

Changes order of conflicting and inserting messages to time, channel and title. They also now use the same time date format.

Attachments (1)

filldatabase.patch (6.6 KB) - added by paulx@… 14 years ago.
Description of the file (optional)

Download all attachments as: .zip

Change History (5)

comment:1 Changed 14 years ago by stuartm

Owner: changed from Isaac Richards to stuartm

Changed 14 years ago by paulx@…

Attachment: filldatabase.patch added

Description of the file (optional)

comment:2 Changed 14 years ago by paul@…

is this the same bug producing output like this..

2006-10-02 05:38:46.987 Connected to database 'mythconverg' at host: localhost
removing existing program: abc-can Always A Bride 2006-10-02T04:30:00 - 2006-10-02T06:00:00
inserting new program    : abc-can Always A Bride Mon Oct 2 04:30:00 2006 - Mon Oct 2 06:00:00 2006

removing existing program: abc-can High Tide At Noon 2006-10-03T01:30:00 - 2006-10-03T03:25:00
inserting new program    : abc-can High Tide At Noon Tue Oct 3 01:30:00 2006 - Tue Oct 3 03:25:00 2006

comment:3 Changed 14 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [12431]) Applies some of the changes to programdata.cpp from Paul Andreassen. Closes #2461

  • Fix - Comparison of floats in mysql doesn't work well, so round up before checking if the star rating has changed.
  • Fix - Use the same format for programme start and end times in the verbose messages.
  • Tidy - Rearranges the time/channel/title in verbose messages, this didn't really seem necessary but it makes it slightly easier to read.

I've left out the utf8 changes as they require a closer look.

I've also left out the inclusion of originalairdate in the comparisons as it didn't work well with radiotimes data. I may add it later if I can find and fix the problem.

comment:4 Changed 14 years ago by paulx@…

[12431] looks good to me.

I don't know much about utf8. Why doesn't the (*todelete).channel and (*tokeep).channel need a .local8Bit()?

Note: See TracTickets for help on using tickets.