Opened 19 years ago
Closed 19 years ago
#248 closed enhancement (fixed)
Enhance scanning of video library to accomodate DVD backups
Reported by: | Owned by: | jdonavan | |
---|---|---|---|
Priority: | minor | Milestone: | 0.19 |
Component: | mythvideo | Version: | head |
Severity: | medium | Keywords: | Ripped DVD playback |
Cc: | Ticket locked: | no |
Description
Currently MythVideo? only looks for files with a set suffix to determine playback attributes (such as the player used). These in include .vob .mpg .avi and others.
I would suggest adding the scanning of directories to determine if these are direct copies of DVDs. For example, of the directory "foo" contains the directories "AUDIO_TS" and "VIDEO_TS", then it is most likely a DVD backup. If added to the list of videos, then it could be played back with "xine --no-splash dvd:/%s/".
At the moment, hacking the database directly seems to be the only way of enabling this bit of functionality.
Attachments (1)
Change History (9)
comment:1 Changed 19 years ago by
comment:2 Changed 19 years ago by
Using dvd backup, I don't get an .ifo extension. Perhaps there is a better way ?
comment:3 Changed 19 years ago by
I took a look at the code. As a special case it probably isn't that hard to code up. There is an if clause in the buildFileList which recurses if it finds a dir. One could insert some code there to check the name of the dir (if VIDEO_TS, then add to m_VideoFiles, if not go down the directory looking for video files. Then put in a VIDEO_TS entry in the extensions table in dbcheck.cpp and see if it works out.
The one issue I haven't figured out is that all of the extension files use the same playcommand. But dvd copies would require a different playcommand by default. It could be changed manually once mythvideo is up, but that is a little cumbersome.
The other thing I don't like is that the dvd copy search is hardcoded in the videoscan class instead of having a little more general solution. I wonder if coding it the easy way, if it would be accepted?
Changed 19 years ago by
Attachment: | mythvideo-dvd-copy-feature.patch added |
---|
add dvd copy playing to mythvideo
comment:4 Changed 19 years ago by
The newly attached patch compiles but has not yet been tested. I intend to test it tonight. It should give a rough of idea of how the support could be implemented. I definitely appreciate any feedback on the patch anyone wants to give.
comment:5 Changed 19 years ago by
Owner: | changed from Isaac Richards to jdonavan |
---|
Donavan, what do you think of this?
comment:6 Changed 19 years ago by
Status: | new → assigned |
---|
comment:7 Changed 19 years ago by
I have patched my 0.18.1 source and tested this. So far it works flawlessly using "xine -pfq --no-splash dvd:/%s/" for playback. It is really nice to have our video library finally integrated into MythTV.
Many thanks,
-P
comment:8 Changed 19 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [7388]) This commit looks a lot bigger then it is.
Close #248 by applying (and fixing) the patch contained therein. Note to submitter: Tabs not spaces, when modifiying dbcheck.cpp you need to bump the schema number and make your changes not change an old schema.
Note: The "video_ts" check was removed it's _always_ "VIDEO_TS" otherwise it's not a DVD.
This also adds a default play commands for ".iso" to match the one for "VIDEO_TS".
The remainder of these chnages are const correctness and formatting changes.
Why not create an .ifo extension and having that be the basis for figuring out if it is a DVD copy?