Opened 14 years ago

Closed 14 years ago

#2503 closed patch (fixed)

Stop PlaybackBox's "disable autoexpire" and "preserve episode" buttons from closing the storage popup.

Reported by: perveilerj@… Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version: 0.20
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When a user wants to prevent an episode from being deleted he has to press 2 buttons in PlaybackBox?'s storage popup: "Disable Auto Expire" and "Preserve this Episode". Pressing either currently causes the storage popup to close, however, so the user has to navigate back into the storage popup a second time to push the second button.

This patch changes that behavior by preventing the popup from closing when either button is pushed. Also, the button text is updated after the press to reflect it's new behavior.

I believe I followed the coding standards, but the coding standards link in the New Ticket HowTo? goes to a blank page so I may have missed something.

Attachments (1)

playbackbox_storage_popup_11349.diff (6.1 KB) - added by perveilerj@… 14 years ago.
Aggh! Attached wrong patch. This is the correct one (also against trunk r11204)

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by perveilerj@…

Aggh! Attached wrong patch. This is the correct one (also against trunk r11204)

comment:1 Changed 14 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham

comment:2 Changed 14 years ago by cpinkham

(In [11418]) Allow a MythPushButton? to be toggled on and off with different text being displayed whether the button is on or off. This will be used in a couple future commits.

References #2503.

comment:3 Changed 14 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [11419]) Convert the 'Auto Expire' and 'Preserve This Episode' buttons on the Storage Popup menu on the Watch Recordings screen to toggle buttons. Also don't close the popup menu when these two buttons are used.

Closes #2503 by applying a different patch than the one attached in order to take advantage of the new toggle ability.

Note: See TracTickets for help on using tickets.