Opened 18 years ago
Closed 17 years ago
#2516 closed defect (wontfix)
upcoming page does not honor 24h time format
| Reported by: | Owned by: | xris | |
|---|---|---|---|
| Priority: | trivial | Milestone: | unknown |
| Component: | mythweb | Version: | head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
mythweb/tv/upcoming page does not honor the 24h clock format setting, and shows times incorrect. If english language is set it is ok, since it shows AM/PM after the time, but while used in Finnish it doesn't use the AM/PM there, but just the time in 12h format. So 5.00 AM becomes 5.00, and 17.00 becomes also 5.00. So the PM is missing then. Probably it is missing from translation, but we don't use AM/PM in Finnish, we have 24 hours in a day.
So probably some kind of a formatter for time, which checks the setting for 12/24h time format, is missing on this page. I have set up the time format for 09:00/21:00 format (24h) in settings.
Here is a sample listing of one day's upcoming recordings, notice it looks like there would be lots of morning show to record, even the two last ones are PM:
ke loka 4, 2006 (07:25 ) ke loka 4, 2006 (11:50 ) ke loka 4, 2006 (05:50 ) -> should be 17:50 ke loka 4, 2006 (08:00 ) -> should be 20:00
All mythtv stuff are from trunk about an hour ago (mythweb revision 11380). This is really minor thing, but thought to report anyway.
Change History (2)
comment:1 Changed 18 years ago by
| Priority: | minor → trivial |
|---|
comment:2 Changed 17 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
"hour format" is for hours that aren't part of a date. There's no easy way to let you choose both. Maybe you would want to put parens around the hours on the upcoming recording page, or maybe just separate it with a comma, etc. There's no way to just let a single global "hour" format be used and still give control over formats of how the hours would interact with the rest of a longer datetime format.
Well, not without completely changing how mythweb deals with dates, which may happen in the future, but not part of a specific solution for this bug.
Started to dig this one out, and noticed it gets fixed by setting the "Date format" -> "Upcoming Recordings:" string on settings page. Righ above the "Hour format" selection. To get the times to 24h format one needs to change all %I to %H in date format strings and remove the %p (for am/pm) from the strings. Blind me.
On the other hand, shouldn't the field "Hour format" do just that automatically, or what's the point of it?