Opened 14 years ago

Closed 14 years ago

#2710 closed defect (fixed)

[11791] breaks compiles

Reported by: xris Owned by: jwestfall
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: high Keywords:
Cc: Ticket locked: no

Description

firewirechannel.cpp: In member function 'virtual bool FirewireChannel::SetChannelByNumber(int)':
firewirechannel.cpp:107: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp:111: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp:137: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp:141: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp:179: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp:183: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp: In member function 'virtual bool FirewireChannel::OpenFirewire()':
firewirechannel.cpp:240: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp:266: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp: In member function 'FirewireChannel::PowerState FirewireChannel::GetPowerState()':
firewirechannel.cpp:291: error: 'avc1394_transaction_block_close' was not declared in this scope
firewirechannel.cpp:323: error: 'avc1394_transaction_block_close' was not declared in this scope

Attachments (1)

fwchan.diff (564 bytes) - added by jwestfall 14 years ago.

Download all attachments as: .zip

Change History (5)

Changed 14 years ago by jwestfall

Attachment: fwchan.diff added

comment:1 Changed 14 years ago by jwestfall

See if the attached patch helps.

Its a bit of a weird problem. avc1394_transaction_block_close() was added in libavc1394 0.5.3 and needs to be called after avc1394_transaction_block() in order to free allocated memory. There doesnt seems to be any way to determine the version installed via its header files.

I sent a note to the author to see what he says.

comment:2 Changed 14 years ago by xris

Seems to compile properly now.

comment:3 Changed 14 years ago by jwestfall

(In [11819]) remove avc1394_transaction_block_close from fw channel changers.

refs #2710 and refs #2722

comment:4 Changed 14 years ago by jwestfall

Resolution: fixed
Status: newclosed

(In [11820]) remove avc1394_transaction_block_close from fw channel change code.

closes #2710, refs #2722

Note: See TracTickets for help on using tickets.