Opened 13 years ago

Closed 13 years ago

#2756 closed patch (fixed)

Use correct input when scanning when source is multiply connected

Reported by: spam@… Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: low Keywords: scanning card source
Cc: Ticket locked: no

Description

ChannelUtil::GetInputName?(int) does not also check the cardid while returning a inputname.

This patch will allow the scanning source to be used on several cards connected to different ports of a diseqc switch. Usefull if you have a fixed dish and a rotor that can receive the same sat. Opening proper ticket for this patch.

Attachments (2)

scan_input_fix.diff (3.8 KB) - added by spam@… 13 years ago.
scanner source patch
2756-v1.patch (8.4 KB) - added by danielk 13 years ago.
Revised patch

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by spam@…

Attachment: scan_input_fix.diff added

scanner source patch

Changed 13 years ago by danielk

Attachment: 2756-v1.patch added

Revised patch

comment:1 Changed 13 years ago by danielk

Owner: changed from Isaac Richards to danielk
Type: defectpatch

Mr. Spam, I was looking at your patch from the other ticket when you opened this ticket. I made some changes which eliminate GetInputName?([cardid,]sourceid) completely from the scanner, since we already know the input name, and replaces it with a safer method in the tranport editor, where we don't. I haven't done any extensive testing yet, and I don't have DiSEqC so if you could look at this that would be helpful...

comment:2 Changed 13 years ago by danielk

Summary: Patch to add cardid to sourceid while scanningUse correct input when scanning when source is multiply connected

comment:3 Changed 13 years ago by spam@…

The patch works great. Tks

comment:4 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [12183]) Fixes #2756. Refs #2695. Allows scanner to work properly when DiSEqC input is connected to a source which is also connected to another DiSEqC input.

Before the refactors in #2695 we did not know which input we were scanning so each input had to be connected to a different source, even if the two sources contained the same channels. Now we pass the inputname to the scanner so that it knows which input it should scan if a source is connected to multiple inputs.

Note: See TracTickets for help on using tickets.