Opened 17 years ago
Closed 17 years ago
#2756 closed patch (fixed)
Use correct input when scanning when source is multiply connected
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.21 |
| Component: | mythtv | Version: | head |
| Severity: | low | Keywords: | scanning card source |
| Cc: | Ticket locked: | no |
Description
ChannelUtil::GetInputName?(int) does not also check the cardid while returning a inputname.
This patch will allow the scanning source to be used on several cards connected to different ports of a diseqc switch. Usefull if you have a fixed dish and a rotor that can receive the same sat. Opening proper ticket for this patch.
Attachments (2)
Change History (6)
Changed 17 years ago by
| Attachment: | scan_input_fix.diff added |
|---|
comment:1 Changed 17 years ago by
| Owner: | changed from Isaac Richards to danielk |
|---|---|
| Type: | defect → patch |
Mr. Spam, I was looking at your patch from the other ticket when you opened this ticket. I made some changes which eliminate GetInputName?([cardid,]sourceid) completely from the scanner, since we already know the input name, and replaces it with a safer method in the tranport editor, where we don't. I haven't done any extensive testing yet, and I don't have DiSEqC so if you could look at this that would be helpful...
comment:2 Changed 17 years ago by
| Summary: | Patch to add cardid to sourceid while scanning → Use correct input when scanning when source is multiply connected |
|---|
comment:4 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [12183]) Fixes #2756. Refs #2695. Allows scanner to work properly when DiSEqC input is connected to a source which is also connected to another DiSEqC input.
Before the refactors in #2695 we did not know which input we were scanning so each input had to be connected to a different source, even if the two sources contained the same channels. Now we pass the inputname to the scanner so that it knows which input it should scan if a source is connected to multiple inputs.
scanner source patch