Opened 13 years ago

Closed 13 years ago

#2766 closed enhancement (fixed)

FreeboxChannelFetcher::ParsePlaylist does not parse dos text files with CRLF

Reported by: anonymous Owned by: danielk
Priority: trivial Milestone: 0.21
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

If a playlist.m3u file contains CRLF instead of simply LF for new lines then it is not parsed and gives the message: Invalid channel list header ...

It would be best if ParsePlaylist? could handle files with CRLF as well as LF for new lines.

Attachments (1)

2766-v1.patch​ (665 bytes) - added by danielk 13 years ago.
Untested fix

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by danielk

Owner: changed from Isaac Richards to danielk

comment:2 Changed 13 years ago by danielk

Type: enhancement → defect

Have you tested the parser in SVN?

It has changed since 0.20, but I don't know if this issue was addressed.

Changed 13 years ago by danielk

Attachment: 2766-v1.patch​ added

Untested fix

comment:3 Changed 13 years ago by danielk

Milestone: unknown → 0.21
Type: defect → enhancement
Version: 0.20 → head

Verified problem exists in SVN head. I've attached a potential fix, I'm not sure it is robust enough (what is the newline convention on Macs these days?)

comment:4 Changed 13 years ago by anonymous

The patch looks simple enough and ought to work just fine as I read the code. I'm not sure I'll have time to test it though.

comment:5 Changed 13 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [12622]) Fixes #2766. Allows IPTV recorder to import channel lists generated on a DOS or MS Windows machine.

Note: See TracTickets for help on using tickets.