Opened 13 years ago

Closed 13 years ago

#2808 closed defect (fixed)

internal dvd player: can't seek through da vinci code dvd properly.

Reported by: skamithi Owned by: skamithi
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

position bar reports the wrong time on the da vinci code dvd, during ffw/rew.

Attachments (7)

dvd_seeking_fix.diff (1.4 KB) - added by skamithi 13 years ago.
dvdnav_sector_search failed to seek to the right sector. changed it to make the da vinci dvd work. seems to work with other dvds too.
time_based_seeking.diff (9.5 KB) - added by skamithi 13 years ago.
time based seeking through a dvd. still a little jerky if u use sticky rew/ffw. trying to see if i can prevent that.
time_based_seeking.2.diff (13.0 KB) - added by skamithi 13 years ago.
2nd attempt. still undergoing testing. should also fix where if hit the skip button repeatedly it jumps back to the beginning of the title.
time_based_seeking.3.diff (13.6 KB) - added by skamithi 13 years ago.
time based seeking seems to work okay for skip ffw and skip back.. this attempt tries to resolve the extreme delay when you use sticky rew/ffw. still undergoing testing. last attempt didn't resolve the slow sticky rew/ffw experience.
time_based_seeking.4.diff (8.5 KB) - added by skamithi 13 years ago.
hopefully this should work well now. figured out a way using the DSI information efficient precise dvd seeking . in dvd nav changed the vobu search through the admap to use binary search algorithm. even at 2x on a dvd drive can now get smooth dvd seeking.
time_based_seeking.5.diff (8.6 KB) - added by skamithi 13 years ago.
some more fixes to the last patch.
time_based_seeking.6.diff (8.7 KB) - added by skamithi 13 years ago.
some more fixes

Download all attachments as: .zip

Change History (17)

comment:1 Changed 13 years ago by skamithi

Status: newassigned

Changed 13 years ago by skamithi

Attachment: dvd_seeking_fix.diff added

dvdnav_sector_search failed to seek to the right sector. changed it to make the da vinci dvd work. seems to work with other dvds too.

comment:2 Changed 13 years ago by skamithi

Summary: internal dvd player: the way it reads the time from the dvd doesn't work for da vinci code dvd.internal dvd player: can't seek through da vinci code dvd properly.

comment:3 Changed 13 years ago by skamithi

Milestone: unknown0.21
Version: 0.20head

comment:4 Changed 13 years ago by skamithi

Resolution: fixed
Status: assignedclosed

(In [12275]) Closes #2808. internal dvd player: fix for seeking through da vinci code. tested it on a few other dvds. seems to work fine.

comment:5 Changed 13 years ago by skamithi

Milestone: 0.21unknown
Resolution: fixed
Status: closedreopened

changeset [12275] caused rewind failures on a cartoon dvd i got today. reopening this ticket. have to implement time based seeking. this should hopefully provide a more precise ffw/rew experience for all dvds. currently mplayer and xine do it in two different ways. going to review their methods and implement time based seeking in the near future. for now, some folks may have serious seeking issues with some dvds..at least [12275] seems to prevent mythtv lockup when seeking fails on some dvds.

Changed 13 years ago by skamithi

Attachment: time_based_seeking.diff added

time based seeking through a dvd. still a little jerky if u use sticky rew/ffw. trying to see if i can prevent that.

Changed 13 years ago by skamithi

Attachment: time_based_seeking.2.diff added

2nd attempt. still undergoing testing. should also fix where if hit the skip button repeatedly it jumps back to the beginning of the title.

Changed 13 years ago by skamithi

Attachment: time_based_seeking.3.diff added

time based seeking seems to work okay for skip ffw and skip back.. this attempt tries to resolve the extreme delay when you use sticky rew/ffw. still undergoing testing. last attempt didn't resolve the slow sticky rew/ffw experience.

comment:6 Changed 13 years ago by skamithi

(In [12348]) Refs #2808. use time based seeking by using dvdnav_time_search. repeatedly hitting skip back/forward when watching a dvd from the dvd drive may cause excessive prebuffer pauses. also noticed that setting the dvd drive to 2x causes seeking to be really slow. so in #2821 i'll try and change the speed during seeking to not make it so slow.

comment:7 Changed 13 years ago by skamithi

(In [12356]) Refs #2808. precise time based dvd seeking not efficient enough. disabling it for now. Also Closes #2847. patch provided by otto.

Changed 13 years ago by skamithi

Attachment: time_based_seeking.4.diff added

hopefully this should work well now. figured out a way using the DSI information efficient precise dvd seeking . in dvd nav changed the vobu search through the admap to use binary search algorithm. even at 2x on a dvd drive can now get smooth dvd seeking.

Changed 13 years ago by skamithi

Attachment: time_based_seeking.5.diff added

some more fixes to the last patch.

Changed 13 years ago by skamithi

Attachment: time_based_seeking.6.diff added

some more fixes

comment:8 Changed 13 years ago by skamithi

Milestone: unknown0.21

comment:9 Changed 13 years ago by skamithi

(In [12401]) Refs #2808. internal dvd player. hopefully better dvd seeking. tried to implement, in an efficient manner, precise dvd seeking if you use skip ffw/rew. makes heavy use of the DSI info in the dvd nav packet. folks who use sticky rew/ffw should not see much difference. thx to otto for testing. see #2808 for more details.

comment:10 Changed 13 years ago by skamithi

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.