Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2821 closed defect (fixed)

internal dvd player: reduce dvd drive speed to 2x.

Reported by: skamithi Owned by: skamithi
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

going to hardcode the dvd drive speed to 2X when playing a dvd in a dvd drive using the internal player.

going to copy the code from the mplayer project.

Attachments (2)

set_dvd_speed.diff (4.8 KB) - added by skamithi 12 years ago.
hardcode dvd speed to 2x.. testing the patch.
eject_fix.diff (1.2 KB) - added by skamithi 12 years ago.
forgot to close the file descriptor.. causes eject to fail..

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by skamithi

Attachment: set_dvd_speed.diff added

hardcode dvd speed to 2x.. testing the patch.

comment:1 Changed 12 years ago by skamithi

(In [12393]) Refs #2821. internal dvd player. Add setdvdspeed() function. will set dvd drive speed to 2x after i finish testing the last patch attached to the dvd seeking ticket #2808.

comment:2 Changed 12 years ago by skamithi

Resolution: fixed
Status: newclosed

(In [12416]) Closes #2821. Allow user to set the DVD drive speed when using the internal dvd player. default is 2x.

comment:3 Changed 12 years ago by skamithi

(In [12454]) Refs #2821. fix speed calculation pointed out on the dev alias.

comment:4 Changed 12 years ago by mythtv at babysimon co uk

Resolution: fixed
Status: closedreopened
Type: enhancementdefect

[I hope reopening this ticket is the right thing to do; if not, sorry.]

This new code seems to cause a problem for me. After playing a DVD, the eject button on the drive no longer works. If I execute the command "eject /dev/hda" the disc comes out and immediately goes back in again, and after that the eject button works.

Commenting out the calls to SetDVDSpeed in DVDRingBuffer fixes this, so it's definitely the speed code I'm afraid.

The speedcontrol command at http://noto.de/speed/speedcontrol.c works for me without this problem.

I'm using r12454, Debian Sid, kernel 2.6.18, and an "_NEC DVD_RW ND-4551A" drive.

Let me know if I can provide any more information.

comment:5 Changed 12 years ago by skamithi

Status: reopenednew

comment:6 Changed 12 years ago by skamithi

Status: newassigned

Changed 12 years ago by skamithi

Attachment: eject_fix.diff added

forgot to close the file descriptor.. causes eject to fail..

comment:7 Changed 12 years ago by skamithi

babysimon, please test the patch. if its okay, i'll commit it.

comment:8 Changed 12 years ago by mythtv at babysimon co uk

Seems to fix it. Thanks!

comment:9 Changed 12 years ago by skamithi

Resolution: fixed
Status: assignedclosed

(In [12467]) Closes #2821. internal dvd player: fix problem where setdvdspeed code prevents dvd from been ejected.

comment:10 Changed 12 years ago by skamithi

(In [12503]) Refs #2821. internal dvd player: call SetDVDSpeed after dvd is open. reduces initial time it takes to read and cache css info.

Note: See TracTickets for help on using tickets.