Opened 13 years ago

Closed 13 years ago

#2831 closed patch (fixed)

MythMusic 0.20 fails to write VBR header to VBR MP3 files (with patch)

Reported by: mythtv@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythmusic Version: 0.20
Severity: medium Keywords:
Cc: Ticket locked: no

Description

There is a bug in the way that mythmusic encodes MP3 files. It fails to add the VBR header/tag/info when encoding in VBR mode. This causes mythmusic (and most all other MP3 players) to calculate the wrong play length of the file.

Attached is a simple patch that fixes this bug. The patch causes mythmusic to write out the proper VBR header/tag/info to the encoded MP3 file. This allows MP3 players to quickly know the correct play length of the file.

Can someone please fold this into the mainline? The diff was taken against 0.20a. It is *extremely* simple (one changed line and two new lines).

-Garrick James

Attachments (1)

mythmusic-vbr.patch (1.0 KB) - added by mythtv@… 13 years ago.
Patch to resolve ticket 2831

Download all attachments as: .zip

Change History (2)

Changed 13 years ago by mythtv@…

Attachment: mythmusic-vbr.patch added

Patch to resolve ticket 2831

comment:1 Changed 13 years ago by paulh

Resolution: fixed
Status: newclosed

(In [12440]) Close #2831 by applying the patch by mythtv (at) jamesplace.org.

MythMusic was failing to write out the proper VBR header causing most players to report incorrect play lengths for all files ripped by MythMusic to VBR mp3 format. Seems to fix the problem with all the players I tried.

Note: See TracTickets for help on using tickets.