Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 7 years ago

Closed 4 years ago

#2896 closed defect (fixed)

mythwelcome, mythshutdown and mtd

Reported by: abarbaccia Owned by: laga
Priority: minor Milestone: 0.24
Component: MythTV - Mythwelcome & Mythshutdown Version: head
Severity: medium Keywords: mythwelcome, mythshutdown, mtd, mythdvd
Cc: Ticket locked: no

Description

Currently if you are ripping a DVD and quit MythFrontend, MythWelcome? will shut down.

mythshutdown should connect to the mtd daemon to check if it is busy in addition to its other checks before giving the "ok" for shutting down.

Attachments (1)

mythshutdown-mtd.diff (2.2 KB) - added by laga 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by danielk

  • Milestone changed from 0.21 to 0.22

comment:2 Changed 6 years ago by laga

As an easier workaround, MTD could just call "mythshutdown --lock" when it's doing work and "mythshutdown --unlock" when it's done.

comment:3 Changed 6 years ago by laga

  • Owner changed from ijr to laga
  • Status changed from new to assigned

Changed 6 years ago by laga

comment:4 Changed 6 years ago by laga

I've added a preliminary patch which checks if MTD is busy.

We're unfortunately running out of status flags for the return code. Return codes on Linux can't be bigger than one byte, hence returning 512 as I do in this patch is not exactly going to work.

As a quick and easy workaround, we could return 1 which means "Transcoding". Thoughts?

comment:5 Changed 5 years ago by stuartm

  • Component changed from mythtv to MythTV - Mythwelcome & Mythshutdown

Laga if you can update the patch using 1 instead of 512 we may as well get this out of the way.

comment:6 Changed 5 years ago by paulh

  • Milestone changed from 0.22 to 0.23

This can wait till 0.23

comment:7 Changed 4 years ago by paulh

  • Milestone changed from 0.23 to 0.24

comment:8 Changed 4 years ago by robertm

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [24069]) Fixes #2896. Check the status of mtd in mythshutdown to prevent cutting a rip/transcode off at the knees. Original patch from Laga, minor modifications to account for changes since then/compile fix under current Qt4 (Applications that use Qt's networking classes need to be configured to be built against the QtNetwork? module).

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.