Opened 17 years ago
Closed 17 years ago
#2939 closed defect (fixed)
AlbumArt::directory is never written, image twitches
| Reported by: | mythtv atsign babysimon co uk | Owned by: | stuartm |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.21 |
| Component: | mythmusic | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
AlbumArt::directory does not get updated as the songs change. This causes needsUpdate() to return true all the time, which (for me at least) leads to some images "twitching" as their aspect ratio changes slightly (presumably a rounding error somewhere).
The attached patch updates AlbumArt::directory and stops this happening.
Attachments (2)
Change History (6)
Changed 17 years ago by
| Attachment: | albumart.patch added |
|---|
comment:1 Changed 17 years ago by
| Milestone: | unknown → 0.21 |
|---|---|
| Owner: | changed from Isaac Richards to stuartm |
comment:2 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 17 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Oops, the patch as committed breaks for folders which do not have an album art file. The attached patch updates AlbumArt::filename too, and ensures that "?" can still be drawn if needsUpdate() is false.
Note: See
TracTickets for help on using
tickets.
Stop the image from twitching