Opened 13 years ago

Closed 12 years ago

#2939 closed defect (fixed)

AlbumArt::directory is never written, image twitches

Reported by: mythtv atsign babysimon co uk Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

AlbumArt::directory does not get updated as the songs change. This causes needsUpdate() to return true all the time, which (for me at least) leads to some images "twitching" as their aspect ratio changes slightly (presumably a rounding error somewhere).

The attached patch updates AlbumArt::directory and stops this happening.

Attachments (2)

albumart.patch (509 bytes) - added by mythtv atsign babysimon co uk 13 years ago.
Stop the image from twitching
AlbumArt2.patch (1.1 KB) - added by mythtv atsign babysimon co uk 12 years ago.
Second time lucky…

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by mythtv atsign babysimon co uk

Attachment: albumart.patch added

Stop the image from twitching

comment:1 Changed 13 years ago by stuartm

Milestone: unknown0.21
Owner: changed from Isaac Richards to stuartm

comment:2 Changed 12 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [12725]) Fixes #2939 - Set AlbumArt::directory to prevent an unnecessary update of the album art when changing tracks.

comment:3 Changed 12 years ago by mythtv atsign babysimon co uk

Resolution: fixed
Status: closedreopened

Oops, the patch as committed breaks for folders which do not have an album art file. The attached patch updates AlbumArt::filename too, and ensures that "?" can still be drawn if needsUpdate() is false.

Changed 12 years ago by mythtv atsign babysimon co uk

Attachment: AlbumArt2.patch added

Second time lucky...

comment:4 Changed 12 years ago by stuartm

Resolution: fixed
Status: reopenedclosed

(In [12992]) Closes #2939

Applies second patch from #2939 to fix the Album Art visualizer for directories without artwork.

Note: See TracTickets for help on using tickets.