Opened 15 years ago
Closed 15 years ago
Last modified 15 years ago
#295 closed patch (fixed)
Patch to update uitype.cpp and uilistbtntype.cpp
Reported by: | Paul | Owned by: | paulh |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | uitype uilistbtntype |
Cc: | Ticket locked: | no |
Description
This patch just fixes a few inconsistencies I found in uitype.cpp and uilistbtntype.cpp whilst writing the new plugin for the MythBurn? scripts.
- The UIListBtnType ignores the draw context and is always drawn
- The UIListBtnType ignores the draworder and is always redrawn regardless
causing it to be redrawn needlessly for each layer a window definition has.
- Several UITypes ignore the hidden flag and are always redrawn.
- UIListBtnType doesn't have a recalculateScreenArea() which causes a few
problems when trying to do a refresh() on a MythThemedDialog?().
- UICheckBoxType has a setState(bool) but no getState() to read back the
current check state.
- UISelectorType has no way to read back what item is currently selected.
- UIImageType when trying to load an image from a specific location can load the
wrong image if an image with the same name exists in the theme or default directory's.
- MythThemedDialog? when updating its list of focus taking widgets doesn't take into
account that some widgets may be hidden or not in the current context.
- UIListBtnType doesn't handle taking focus and loosing focus very well.
- others that I have forgot about.
I'd be very grateful if one of the devs could look over the patch and commit it so that anyone who wants to try the MythBurn? plugin don't have to start patching myth they just need to get the latest svn version.
thanks, Paul
Attachments (1)
Change History (5)
Changed 15 years ago by
Attachment: | mythtv.diff added |
---|
comment:1 Changed 15 years ago by
Just a gentle reminder that this patch is waiting to be applied. Not sure if it just slipped though the net or if there is a reason it didn't get applied during the last round of commits?
I'd like to make public the native MythTV plugin for the Mythburn scripts soon. A private tester has said it is working well and is ready for release. Is there any desire to add this sort of DVD creation functionality to the official myth distribution?
Paul
comment:2 Changed 15 years ago by
Owner: | changed from Isaac Richards to paulh |
---|
comment:3 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
patch to fix uitypes