Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#295 closed patch (fixed)

Patch to update uitype.cpp and uilistbtntype.cpp

Reported by: Paul Owned by: paulh
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords: uitype uilistbtntype
Cc: Ticket locked: no


This patch just fixes a few inconsistencies I found in uitype.cpp and uilistbtntype.cpp whilst writing the new plugin for the MythBurn? scripts.

  • The UIListBtnType ignores the draw context and is always drawn
  • The UIListBtnType ignores the draworder and is always redrawn regardless

causing it to be redrawn needlessly for each layer a window definition has.

  • Several UITypes ignore the hidden flag and are always redrawn.
  • UIListBtnType doesn't have a recalculateScreenArea() which causes a few

problems when trying to do a refresh() on a MythThemedDialog?().

  • UICheckBoxType has a setState(bool) but no getState() to read back the

current check state.

  • UISelectorType has no way to read back what item is currently selected.
  • UIImageType when trying to load an image from a specific location can load the

wrong image if an image with the same name exists in the theme or default directory's.

account that some widgets may be hidden or not in the current context.

  • UIListBtnType doesn't handle taking focus and loosing focus very well.
  • others that I have forgot about.

I'd be very grateful if one of the devs could look over the patch and commit it so that anyone who wants to try the MythBurn? plugin don't have to start patching myth they just need to get the latest svn version.

thanks, Paul

Attachments (1)

mythtv.diff (13.7 KB) - added by Paul 16 years ago.
patch to fix uitypes

Download all attachments as: .zip

Change History (5)

Changed 16 years ago by Paul

Attachment: mythtv.diff added

patch to fix uitypes

comment:1 Changed 16 years ago by Paul

Just a gentle reminder that this patch is waiting to be applied. Not sure if it just slipped though the net or if there is a reason it didn't get applied during the last round of commits?

I'd like to make public the native MythTV plugin for the Mythburn scripts soon. A private tester has said it is working well and is ready for release. Is there any desire to add this sort of DVD creation functionality to the official myth distribution?


comment:2 Changed 16 years ago by paulh

Owner: changed from Isaac Richards to paulh

comment:3 Changed 16 years ago by paulh

Resolution: fixed
Status: newclosed

(In [7542]) Close #295 by applying the patch. Fixes a few inconsistencies with the uitypes.

comment:4 Changed 15 years ago by anonymous

yeah I am dieing for this please let me know when it is!!

Note: See TracTickets for help on using tickets.