Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#2978 closed enhancement (fixed)

Expand "Action on playback exit" option to include Live TV

Reported by: Neil McBride <neil@…> Owned by: skamithi
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords: playback exit Live TV
Cc: Ticket locked: no

Description

As I seem to be constantly pressing the 'escape' button on my remote too many times or to clear the OSD just as it clears itself then shutting down Live TV (apparently always in a bad place I'm told by others ...), I decided to go about expanding the existing action on playback exit code to include Live TV in it's work.

The patch attached adds two new options to the "Action on playback exit" so that a user may now choose to Prompt for Live TV only or always prompt (including Live TV). The existing behaviour was not changed other than modifying the text for the pre-existing "Always Prompt" to be "Always Prompt (excluding Live TV)" The only thing I'm not sure about is the fact that bookmarks are set even for Live TV if the playback exit option is set to do so. I'm not really sure this is worthwhile considering it will be the end of the file but the code to display the OSD menu when exiting Live TV gives the option to do so for the moment.

I've tested it against head and it all seems to work well. Is this something that might be suitable to be added to the trunk?

Thanks!

Attachments (4)

prompt_livetv_exit_r12631.diff​ (4.0 KB) - added by Neil McBride <neil@…> 17 years ago.
prompt_livetv_exit_r12644-with-new-fns.diff​ (7.2 KB) - added by Neil McBride <neil@…> 17 years ago.
ticket_2748_final.diff​ (7.2 KB) - added by skamithi 17 years ago.
final patch. made some minor changes in the positioning of the menu options so it matches what is currentl there. will test run it for a little while before commiting.
delete_allowed_fix.diff​ (467 bytes) - added by Neil McBride <neil@…> 17 years ago.

Download all attachments as: .zip

Change History (15)

Changed 17 years ago by Neil McBride <neil@…>

Attachment: prompt_livetv_exit_r12631.diff​ added

comment:1 Changed 17 years ago by skamithi

Owner: changed from Isaac Richards to skamithi

comment:2 Changed 17 years ago by skamithi

Milestone: 0.21 → unknown

comment:3 Changed 17 years ago by Neil McBride <neil@…>

Cc: neil@… removed

I've cleaned this up some and made the menu orders when exiting standard across the type of program being watched. The patch adds two new functions to the TV class as outlined below. These aren't essential, but the code ends up being much cleaner, and these functions should be suitable for other uses as well.

  • Swapped around the menu order so the first option is to just exit to the menu for all types. This seems to make the most sense considering 'keep watching' can be achieved by pressing stop again, and setting a bookmark or deleting would require actual navigation of the menu, while simply exiting which I would assume would be the most frequent option used is a simple matter of pressing stop then select.
  • Added two functions BookmarkAllowed? and DeleteAllowed? to return true/false whether or not the action is appropriate for what is being watched. This and the reordering allowed me to consolidate some of the code and make it a littler cleaner. I'm told there is a unified bookmark system being written so I expect at least one of these will not be necessary once that is complete.
  • Removed the code that sets bookmarks and watched flags for Live TV - I can't think of a reason for it at least.

I've tested with Live TV, recordings, videos and DVD, including the optional bookmarking. It all seems to work well. Let me know if there's any problems.

Changed 17 years ago by Neil McBride <neil@…>

Attachment: prompt_livetv_exit_r12644-with-new-fns.diff​ added

comment:4 Changed 17 years ago by skamithi

Status: new → assigned

Changed 17 years ago by skamithi

Attachment: ticket_2748_final.diff​ added

final patch. made some minor changes in the positioning of the menu options so it matches what is currentl there. will test run it for a little while before commiting.

comment:5 Changed 17 years ago by skamithi

Resolution: → fixed
Status: assigned → closed

comment:6 Changed 17 years ago by skamithi

Changeset [12971] is meant to be attached to this ticket.

comment:7 Changed 17 years ago by anonymous

Resolution: fixed
Status: closed → reopened

It seems the final patch allows the 'delete' option to show when the internal player is being used to watch videos through MythVideo?. I know the one before it didn't and selecting the delete option when watching a video doesn't do anything anyway.

comment:8 Changed 17 years ago by Neil McBride <neil@…>

I can't work out why the delete option was suddenly turning up from one patch to the next, but I'm attaching a small patch that fixes the problem.

Changed 17 years ago by Neil McBride <neil@…>

Attachment: delete_allowed_fix.diff​ added

comment:9 Changed 17 years ago by skamithi

(In [13001]) Refs #2978. Resolve problem where 'delete' option shows up in the exit prompt when exiting a video(non-dvd) played by the internal player.

comment:10 Changed 17 years ago by skamithi

Resolution: → fixed
Status: reopened → closed

comment:11 Changed 17 years ago by skamithi

(In [13716]) Refs #2978. allow bookmark menu option for videos.

Note: See TracTickets for help on using tickets.