Opened 13 years ago

Closed 13 years ago

#2983 closed defect (fixed)

Recording List Menu not working 100%

Reported by: Neil McBride <neil@…> Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I'm running svn trunk at the moment and have just found that when in the watch recordings screen, changing the group filter via the recording list menu no longer works. The windows open up and all of the appropriate options are given - however once selected, nothing happens. A similar problem happens with the change group view and change group password options with the no changes being effected by either window. I'm not too familiar with the way the UI works yet but it looks to me like the UI is returning rejected instead of accepted - though the Playlist options menu seems to work fine.

Attachments (2)

2983-v1.patch (386 bytes) - added by danielk 13 years ago.
This fixes the group view dialog, however it may cause other problems.
2983-v2.patch (940 bytes) - added by danielk 13 years ago.
Updated patch, it appears default handler is only used to handle ESC (LEFT if arrow accellerations is enabled)

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by Neil McBride <neil@…>

I did some further testing to this and removed some of the recently added code that looks to have been a part #2426.

In mythdialogs.cpp, the functions accept and reject are now overloaded for MythPopupBox?. In each of these, they call MythDialog::done() with the appropriate value and then both emit popupDone() which results in MythPopupBox::defaultExitHandler() being called, which then calls done(-1) thus removing the previously stored result value.

I removed both emit lines, recompiled and tried again. That seems to resolve the problems I listed when submitting this ticket but I'm not sure what the reason for the code is in the first place and what removing it will break. I'll leave working that out to the person working on the new code effort in there.

Hope that helps some.

comment:2 Changed 13 years ago by danielk

Milestone: unknown0.21
Owner: changed from Isaac Richards to danielk

Changed 13 years ago by danielk

Attachment: 2983-v1.patch added

This fixes the group view dialog, however it may cause other problems.

Changed 13 years ago by danielk

Attachment: 2983-v2.patch added

Updated patch, it appears default handler is only used to handle ESC (LEFT if arrow accellerations is enabled)

comment:3 Changed 13 years ago by danielk

I'm testing a patch which just reverts [12624] and [12629] for now.

I need to make larger changes in MythDialog? to properly handle a canceled dialog in all cases, this in turn will require more testing and will take a while.

comment:4 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

(In [12635]) Refs #2909. Fixes #2983. Reverts [12624] and [12629], until I can fix some problems with accept/reject.

This changes the plugin ABI and will require recompiling the plugins after installing the updated MythTV.

Note: See TracTickets for help on using tickets.