Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3017 closed enhancement (fixed)

Right-justified button text

Reported by: Dagmar d'Surreal Owned by: Isaac Richards
Priority: trivial Milestone: 0.21
Component: mythtv Version: 0.20
Severity: low Keywords:
Cc: Ticket locked: no

Description

At the moment text placement in buttons is limited to just two modes, left-justified and centered. It would be more useful to simply deprecate (or eliminate) the <centered> element and add a <justification> element with possible values of left (default), center, and right.

Attachments (1)

mythtv-0.20fixes-halignvaligntags.diff (3.5 KB) - added by anonymous 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by anonymous

comment:1 Changed 13 years ago by Dagmar d'Surreal

Okay, so I got a little proactive and made a patch to do it myself, implementing <halign> as well as <valign> (might as well get vertical alignment control to complete the hat trick).

<halign> accepts left, right, and center as values. <valign> accepts top, bottom, and center as values.

I did manage to preserve the inexplicable and undocumented behaviour with respect to Japanese fonts assumedly being drawn along a center line instead of a baseline.

This definitely applies against 0.20-fixes 12674 SVN, but will probably apply to 0.20 and HEAD as well.

comment:2 Changed 13 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [13262]) Closes #3017 by applying patch from Dagmar.

Adds valign and halign elements to the menu theme xml. This gives theme developers a little more control.

valign accepts left, right and center halign accepts top, bottom and center

The 'centered' element is deprecated and should no longer be used in new themes. Old themes will be updated shortly.

comment:3 Changed 13 years ago by stuartm

Milestone: unknown0.21
Note: See TracTickets for help on using tickets.