Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3030 closed defect (fixed)

Shortcut keys active while editing a HostComboBox

Reported by: luitjens@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When configuring the mythfrontend sound and setting the mixer or the sound device shortcut keys are active. For instance if I type alsa:mixed-analog the front end jumps to the program guide from hitting 'g'.

Attachments (1)

patch.diff (576 bytes) - added by luitjens 13 years ago.
No longer allow jumps if MythComboBox? is editable

Download all attachments as: .zip

Change History (5)

comment:1 Changed 13 years ago by luitjens@…

Summary: Shortcut keys active while editing text boxes in sound configuration pageShortcut keys active while editing a HostComboBox

This appears to be a flaw with the data structure HostComboBox?. I edited the source and changed the editable parameter to true in a different menu and it exhibited the same behavior. However the HostLineEdit? prevents this from happening the HostComboBox? should also do, at least when the editable field is set to true.

Changed 13 years ago by luitjens

Attachment: patch.diff added

No longer allow jumps if MythComboBox? is editable

comment:2 Changed 13 years ago by luitjens

I have attached a patch which fixes the problem. Could someone please review and commit.

The problem was MythComboBox? did not set the allowJumps flag when translating a key press causing the default (allow) to be used. We can determine if the box is editable by looking at the variable allowVirtualKeyboard. If this is true then the box is editable and we want to disable jumps. Alternatively if using this variable to determine this a second variable could be added for this check.

Thanks Justin

comment:3 Changed 13 years ago by paulh

Resolution: fixed
Status: newclosed

(In [12716]) Don't allow jumps while editing the text in a MythComboBox?. Patch by luitjens. Fixes #3030.

comment:4 Changed 13 years ago by paulh

(In [12717]) Also need to disallow jumps while entering text using the popup keyboard. Refs #3030.

Note: See TracTickets for help on using tickets.