Opened 14 years ago

Closed 13 years ago

#305 closed defect (fixed)

Single Transport Scan tunes twice.

Reported by: stuarta@… Owned by: danielk
Priority: trivial Milestone: 0.20
Component: mythtv Version: head
Severity: low Keywords: single transport scan
Cc: Ticket locked: no

Description

While researching #304 I discovered that when trying to do a single transport scan the multiplex is tuned to twice.

Firstly in ScanWizardScanner::SpawnTune?():212 via

ok = scanner->GetDVBChannel()->TuneMultiplex?(mplexid);

Then tuned again through ScanWizardScanner::HandleTuneComplete?(void):693 via

ok = scanner->ScanTransport?(parent->transport());

One of these tunings is unneccessary. Which one should we remove?

Change History (4)

comment:1 Changed 14 years ago by danielk

Milestone: 0.190.20
Owner: changed from Isaac Richards to danielk
Priority: minortrivial
Severity: mediumlow
Status: newassigned

I'm wondering if SpawnTune? is needed at all, but I'm not going to touch this for now as the DVB stuff is finally stabilizing.

comment:2 Changed 14 years ago by John Pullan <john.pullan@…>

I seem to remember that this was needed so that the UI could continue to work while we were doing the tune.

comment:3 Changed 14 years ago by john.pullan@…

At a guess I'd say the first one.

As I noted above the first tune is done in a separate thread to keep the UI going. It then adds the transport to the list to be scanned which will then generate another tune (this is also on another thread and so the UI should be running ok). This *should* result in a noop (nothing has changed) and we carry on.

For the "Full Tuned Scan" mode, it looks like we do need the initial tuning in a separate thread, just to generate the mplex list.

comment:4 Changed 13 years ago by danielk

Resolution: fixed
Status: assignedclosed

Fixed in [9540].

Note: See TracTickets for help on using tickets.