Opened 13 years ago

Closed 13 years ago

#3085 closed defect (fixed)

Smart Playlist: search criteria specifying 'date imported' fails

Reported by: briand <turbo at talstar dot com> Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Cannot create a smart playlist using 'Date Imported'; no match against music library is ever found, regardless of date(s) entered.

The code in smartplaylist.cpp is specifying music_songs.date_added, but the actual column in the database is music_songs.date_entered

Patch attached.

Attachments (1)

fix_smartplaylist.patch (724 bytes) - added by briand <turbo at talstar dot com> 13 years ago.
patch to correct smart playlist

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by briand <turbo at talstar dot com>

Attachment: fix_smartplaylist.patch added

patch to correct smart playlist

comment:1 Changed 13 years ago by stuartm

Milestone: unknown0.21
Owner: changed from Isaac Richards to stuartm

comment:2 Changed 13 years ago by briand <turbo@…>

The currently attached patch does not completely fix the problem, only corrects the column specified in the Smart Playlist Editor. Even after this change, the 'Date Imported' logic does not find any files. Additionally, the 'Last Played' choice is non-functional. I suspect incorrect/incomplete voodoo in the evaluateDateValue function. (I changed the type on those two choices from ftDate to ftString, and the functions "sort of" work [in as much as dates are not strings]) -- at least, they then start to return qualifying rows and enable the [Save] and [Show Results] buttons.

comment:3 Changed 13 years ago by stuartm

(In [12924]) Refs #3085

Correct column name in the smart playlist code, this allows "Date Imported" rules to work correctly.

comment:4 Changed 13 years ago by stuartm

Status: newassigned

I don't use the smart playlist function so I'm not very familiar with it. However with the column name fix in place it seems to work as expected for me. Could you give an example of a rule which isn't working for you?

comment:5 Changed 13 years ago by stuartm

Resolution: fixed
Status: assignedclosed

Fixed by [12924].

Note: See TracTickets for help on using tickets.