Opened 13 years ago

Closed 13 years ago

#3142 closed patch (fixed)

code cleanup; constness patch for Metadata

Reported by: myth@… Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythmusic Version: 0.20
Severity: low Keywords:
Cc: Ticket locked: no

Description

Patch with some code cleanup things for Metadata, not any functionality change ;

  • add constness to the various getter methods in Metadata
  • uses 'good' C++ style initialisation for the standard case constructor
  • move code that set artist/album/genre gets set to sane (Unknown Artist/AlbumGenre?) to a function.

Attachments (1)

metadata-const.patch (9.3 KB) - added by myth@… 13 years ago.
patch with Metadata fixes.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by myth@…

Attachment: metadata-const.patch added

patch with Metadata fixes.

comment:1 Changed 13 years ago by paulh

Eskil, I think maybe you included a few things in this patch that you didn't mean to?

QByteArray AlbumArt?() const; void setAlbumArt(const QByteArray &data); QString FormatInfo?(); MythThemedDialog? *createEditorDialog (void);

comment:2 Changed 13 years ago by myth@…

Yeah, I didn't mean to remove setArtistAndTrackFormats, but other than that, it's pretty much as I intended.

  • Add const to all getters
  • Use initialisation lists in constructors (I'm that kind of guy)
  • 1 method to handle blank artist/album fields.

comment:3 Changed 13 years ago by paulh

Resolution: fixed
Status: newclosed

(In [13138]) Close #3142 by applying the patch by Eskil.

Some code cleanup things for Metadata, not any functionality change;

  • add constness to the various getter methods in Metadata
  • uses 'good' C++ style initialisation for the standard case constructor
  • move code that set artist/album/genre gets set to sane (Unknown Artist/AlbumGenre?) to a function.
Note: See TracTickets for help on using tickets.