Opened 12 years ago

Closed 9 years ago

#3152 closed enhancement (wontfix)

Add GUI for transcoder\playback filters

Reported by: malban@… Owned by: danielk
Priority: minor Milestone: unknown
Component: MythTV - General Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Currently filter settings are modified using text entry. This is not a good solution for remote controls and is prone to entry error. It also makes it very hard for users to discover this feature.

This patch replaces the text entry for the transcoder profile\general playback\channel video\channel output filter chain settings with a button that opens a configuration dialog. The dialog is a list of the filters in the chain along with an (add new filter) item. Selecting a filter opens a configuration dialog to modify the parameters for that filter. The menu button opens a popup to move the filter in the chain or delete it.

Selecting (add new filter) generates a list of available filters dynamically using the FilterManager? class. The configuration dialogs for each filter type are also generated dynamically based on parameter descriptions that have been added to each filter. Each parameter has help text associated with it that describes it's purpose.

The quickdnr configuration only allows for 1 parameter instead of allowing for 1, 2, or 4. This could be changed to one of the other options, but it is not clear how to easily allow for a variable amount of parameters with this interface.

Attachments (8)

filterwizard.patch.gz (7.2 KB) - added by malban@… 12 years ago.
filterwizard.patch.2.gz (7.4 KB) - added by malban@… 12 years ago.
added descriptions to filter list and clean up code
filterwizard.patch.3.gz (7.4 KB) - added by malban@… 12 years ago.
updated to match current revision
filterwizard4.patch (37.1 KB) - added by Marc Alban <marcalban@…> 11 years ago.
Updated patch to rev. 18555
filter_gui.patch (68.6 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Updated patch for filter configuration screens using MythUI.
helptext.patch (3.1 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Split out parsing help text from the theme file to its own patch.
filter_gui.2.patch (77.0 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Updates the filter configuration screen patch with a wide theme file and several fixes pointed out by gbee. Also, the screenshots at http://www.mythtv.org/wiki/Filter_Wizard have been updated.
filter_gui.3.patch (82.0 KB) - added by Marc Alban <marcalban@…> 10 years ago.
Updates the filter configuration screen patch to trunk. Adds access to the new interface to the PlaybackProfileItemConfig? screen.

Download all attachments as: .zip

Change History (22)

Changed 12 years ago by malban@…

Attachment: filterwizard.patch.gz added

comment:1 Changed 12 years ago by anonymous

Summary: Add GUI for transcoder\playback fitlersAdd GUI for transcoder\playback filters

Changed 12 years ago by malban@…

Attachment: filterwizard.patch.2.gz added

added descriptions to filter list and clean up code

Changed 12 years ago by malban@…

Attachment: filterwizard.patch.3.gz added

updated to match current revision

comment:2 Changed 11 years ago by laga

Status: newinfoneeded_new

That sounds like a neat thing to have.

Can you update this patch to trunk, possibly using MythUI?

Changed 11 years ago by Marc Alban <marcalban@…>

Attachment: filterwizard4.patch added

Updated patch to rev. 18555

comment:3 Changed 11 years ago by Marc Alban <marcalban@…>

Updated the patch against the latest trunk.

I just got it back into a functional state, but I'll look into creating another patch that uses MythUI once I understand it better.

comment:4 Changed 11 years ago by stuartm

Status: infoneeded_newnew

comment:5 Changed 11 years ago by stuartm

Milestone: unknown0.22

comment:6 Changed 10 years ago by laga

Status: newinfoneeded_new

Can you update this patch to MythUI?

comment:7 Changed 10 years ago by Marc Alban <marcalban@…>

I was able to get the interface working with MythUI for the most part, but since this interface is accessed from configuration screens that have not been converted to MythUI yet I couldn't figure out how to get the screen draw ordering correct.

It's probably best to move this enhancement to the next release when the configuration screens are converted.

comment:8 Changed 10 years ago by robertm

Status: infoneeded_newnew

Postponing for .23 per patch author. Feel free to drop by #mythtv on Freenode if you need help re: the draw ordering.

comment:9 Changed 10 years ago by robertm

Milestone: 0.22unknown

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: filter_gui.patch added

Updated patch for filter configuration screens using MythUI.

comment:10 Changed 10 years ago by Marc Alban <marcalban@…>

The new patch adds MythUI screens for editing the filters of recording profiles and channels. It also adds the ability to read in a <helptext> tag from the schema for MythUITypes.

I'll add some updated screenshots to http://www.mythtv.org/wiki/Filter_Wizard. The current ones are out of date.

comment:11 Changed 10 years ago by Marc Alban <marcalban@…>

I forgot to add a wide-screen version of the theme file, so I'll add that as well.

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: helptext.patch added

Split out parsing help text from the theme file to its own patch.

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: filter_gui.2.patch added

Updates the filter configuration screen patch with a wide theme file and several fixes pointed out by gbee. Also, the screenshots at http://www.mythtv.org/wiki/Filter_Wizard have been updated.

comment:12 Changed 10 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newassigned

Changed 10 years ago by Marc Alban <marcalban@…>

Attachment: filter_gui.3.patch added

Updates the filter configuration screen patch to trunk. Adds access to the new interface to the PlaybackProfileItemConfig? screen.

comment:13 Changed 10 years ago by stuartm

Component: mythtvMythTV - General

comment:14 Changed 9 years ago by robertm

Resolution: wontfix
Status: assignedclosed

Doesn't seem likely that this will ever be done this way. Closing for lack of interest.

Note: See TracTickets for help on using tickets.