Opened 14 years ago

Closed 14 years ago

#3302 closed patch (fixed)

Do not update mfdb min/max hour for MythFillGrabberSuggestsTime

Reported by: sphery <mtdean@…> Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythfilldatabase Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Currently, after getting a next suggested run time from DataDirect?, mythfilldatabase will set the MythFillMinHour? to the hour during which the suggested run time occurs and the MythFillMaxHour? to 2 hours later than the new MythFillMinHour?. For users who shut down their systems, this can mean missing one or more mythfilldatabase runs.

For example, if DataDirect? provides a next suggested run time of 08:30 on some day, mfdb will set the MythFillMinHour? to 8 and the MythFillMaxHour? to 10. If the user shuts down the Myth system (i.e. using mythshutdown or just manually) for the period from 08:00 to 11:00, mythfilldatabase will not be allowed to run that day. If the user typically shuts down the myth system during the work day, this could mean that mfdb will never automatically run again. This has prompted some users to create their own run scripts and/or cron jobs rather than using the provider's suggested run time.

Since the housekeeper checks to verify that the suggested run time is before the current time, changing the MythFillMinHour? and MythFillMaxHour? in this way does not help, but can actually cause harm. Therefore, I recommend removing the code that modifies the min/max hours. To ensure this works properly, we need to also modify the MythFillMinHour? to be -1 (which the housekeeper takes to mean MythFillMinHour?=0 and MythFillMaxHour?=24) for those users using MythFillGrabberSuggestsTime?.

The attached patches make these changes. The patch mythtv-DataDirect?-no_update_min_max_hour.patch removes the code changing the min/max hours and mythtv-DataDirect?-no_update_min_max_hour-dbcheck.patch changes MythFillMinHour? to -1 if MythFillGrabberSuggestsTime? = 1. The dbcheck patch is separate so users wanting to update the DataDirect? behavior can do so without worrying about DBSchemaVer. It won't hurt if the dbcheck update is applied multiple times.

If you prefer for mfdb to simply update MythFillMinHour? to -1 every time (and not do a one-time change in dbcheck), please let me know. This approach has the benefit that users who turn on MythFillGrabberSuggestsTime? after specifying their own times will not have to also change MythFillMinHour?. I only chose the dbcheck approach because setting and resetting MythFillMinHour? to -1 every single day seemed overkill.

See, also, the thread at http://www.gossamer-threads.com/lists/mythtv/users/263209#263209 for discussion of the issue.

Attachments (6)

mythtv-DataDirect-no_update_min_max_hour.patch (1.1 KB) - added by sphery <mtdean@…> 14 years ago.
mythtv-DataDirect-no_update_min_max_hour-dbcheck.patch (1.3 KB) - added by sphery <mtdean@…> 14 years ago.
mythtv-DataDirect-no_update_min_max_hour-dbcheck-20070413.patch (1.5 KB) - added by sphery <mtdean@…> 14 years ago.
Adds the missing ClearSettingsCache?
mythtv-DataDirect-no_update_min_max_hour-20070413.patch (1.2 KB) - added by sphery <mtdean@…> 14 years ago.
mythtv-DataDirect-MythFillGrabberSuggestsTime-ignore_min_max_hour-20070414.patch (1.8 KB) - added by sphery <mtdean@…> 14 years ago.
ignores min/max if grabber suggests time
mythtv-DataDirect-MythFillGrabberSuggestsTime-ignore_min_max_hour-settings_help.patch (828 bytes) - added by sphery <mtdean@…> 14 years ago.
help text mentioning that min/max are ignored when grabber suggests time

Download all attachments as: .zip

Change History (10)

Changed 14 years ago by sphery <mtdean@…>

Changed 14 years ago by sphery <mtdean@…>

Changed 14 years ago by sphery <mtdean@…>

Adds the missing ClearSettingsCache?

comment:1 Changed 14 years ago by sphery <mtdean@…>

The more I think about it, the less I like the idea of the user being able to "break" mythfilldatabase by specifying improper mfdb min/max hour with MythFillGrabberSuggestsTime?. mythtv-DataDirect?-no_update_min_max_hour-20070413.patch changes the approach so the dbcheck is no longer needed and instead simply sets and resets the value of MythFillMinHour? every day. If used, only mythtv-DataDirect?-no_update_min_max_hour-20070413.patch should be applied.

Changed 14 years ago by sphery <mtdean@…>

comment:2 Changed 14 years ago by sphery <mtdean@…>

Another different approach. The patch mythtv-DataDirect?-MythFillGrabberSuggestsTime?-ignore_min_max_hour-20070414.patch simply ignores the values of MythFillMinHour? and MythFillMaxHour? if the grabber supports next time and MythFillGrabberSuggestsTime? is enabled. Again, this should be applied in place of the previously uploaded patches.

Also included a help text patch, mythtv-DataDirect?-MythFillGrabberSuggestsTime?-ignore_min_max_hour-settings_help.patch .

Changed 14 years ago by sphery <mtdean@…>

ignores min/max if grabber suggests time

Changed 14 years ago by sphery <mtdean@…>

help text mentioning that min/max are ignored when grabber suggests time

comment:3 Changed 14 years ago by stuartm

Owner: changed from stuartm to cpinkham

comment:4 Changed 14 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [13250]) Make the housekeeper ignore the MythFillMinHour? and MythFillMaxHour? settings when MythFillGrabberSuggestsTime? is enabled. This allows mythfilldatabase to run anytime if it couldn't run at the suggested time. This is especially useful for people that shutdown their backends.

Since we're not honoring the min/max time settings anymore for users with MythFillGrabberSuggestsTime? turned ON, don't bother setting these fields inside the DataDirect? grabber. Also update the help text for MythFillGrabberSuggestsTime? to reflect that the min/max values are not used when this setting is enabled.

Closes #3302 using patches submitted by Michael T. Dean.

Note: See TracTickets for help on using tickets.