Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#3328 closed patch (fixed)

Fix crash in AlbumArtImages on music startup

Reported by: anonymous Owned by: paulh
Priority: minor Milestone: unknown
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If AlbumArt? visualiser is chosen at startup, chosing "Play Music" will crash as it hits an uninitialised pointer to a Metadata

Attached patch initialises it to NULL, and on a NULL Metadata don't try to find album art.

Attachments (1)

init-metadata.patch (1.9 KB) - added by myth@… 13 years ago.
patch to initialise m_parent to 0.

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by myth@…

Attachment: init-metadata.patch added

patch to initialise m_parent to 0.

comment:1 Changed 13 years ago by stuartm

Owner: changed from Isaac Richards to paulh
Version: unknownhead

Specifically it will crash on an empty playlist. Reassigning to Paul as I'd already made him aware of the problem.

comment:2 Changed 13 years ago by paulh

Resolution: fixed
Status: newclosed

(In [13305]) Don't try to find album art images if the passed metadata pointer is NULL. Make sure some variables are initialised properly in MainVisual?.

Fixes #3328.

Note: See TracTickets for help on using tickets.