Opened 13 years ago

Closed 13 years ago

#3375 closed enhancement (fixed)

Mythbrowser enhancements

Reported by: anonymous Owned by: paulh
Priority: minor Milestone: 0.21
Component: mythbrowser Version: head
Severity: medium Keywords: completed title
Cc: Ticket locked: no

Description

I have created a couple of patches to improve (IMHO) mythbrowser:

  • The first of the patches is to add a keybinding for prevtab to complement the existing nexttab
  • The second patch adds proper detection for the page loading completion. Originally if you loaded a page with a meta refresh for scheduling the page to refreshed some time later the page load would never be considered completed. I added another signal (completed(bool)) to the completed() slot, this is emitted when the page has completed with further events pending (like a meta refresh).
  • I also created a patch that would set the tab title to "Loading..." while a page is loading, then when the page has loaded sets the tab text to the title of the page if it is defined and not whitespace, if not it falls back to the url.

Applying the patches:

  • mythbrowser-1-keybinding.diff should apply independently.
  • mythbrowser-2-completed.diff is the page completed patch only.
  • mythbrowser-2-completed_loading.diff incorporates mythbrowser-2-completed.diff as well as the "Loading..." and page title vs url changes.

Attachments (3)

mythbrowser-1-keybinding.diff (1.0 KB) - added by anonymous 13 years ago.
mythbrowser-2-completed.diff (771 bytes) - added by anonymous 13 years ago.
mythbrowser-2-completed_loading.diff (5.7 KB) - added by anonymous 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by anonymous

Changed 13 years ago by anonymous

Changed 13 years ago by anonymous

comment:1 Changed 13 years ago by anonymous

I forgot to add that these changes have been used for a long time and I originally created them against 0.19 fixes r10012.

The original patch applied cleanly against trunk, I just split it into the different .diff files.

Let me know if there are any probs.

Cheers.

comment:2 Changed 13 years ago by anonymous

Argh, I created this anonymously... If you need to my email is roo dot watt at gmail dot com

Cheers,

Roo

comment:3 Changed 13 years ago by paulh

Milestone: unknown0.21
Owner: changed from Isaac Richards to paulh
Version: unknownhead

comment:4 Changed 13 years ago by paulh

(In [13382]) Add new PREVTAB keybinding to complement the existing NEXTTAB binding in MythBrowser?.

Patch from roo (at) gmail (dot) com. Refs #3375.

comment:5 Changed 13 years ago by paulh

Resolution: fixed
Status: newclosed

(In [13385]) In MythBrowser? set the tab title to "Loading..." while a page is loading, then when the page has loaded set it to the title of the page if available, if not fall back to using the URL.

Also improves the page loading completed detection.

I just changed things so the 'Loading...' string is translateable.

Closes #3375. Patch from roo (at) gmail (dot) com.

Note: See TracTickets for help on using tickets.