opengl painter doesn't handle GUI offset correctly in drawTimeout

[anonymous]

MythMainWindow? moves its origin to xoffset,yoffset. In drawTimeout if the painter doesn't support clipping (which the opengl painter says it doesn't), the repaint region is forced to include the whole screen via screenRect. Unfortunately, screenRect contains the xoffset/yoffset, causing the redraw to redraw an strange set of rectangles. Normally this doesn't show up as a visible problem because it tends to be a superset of the visible screen. In the presence of alphapulse, however, it causes the background image to get redrawn 1 extra time at the end, after the pulsing image, erasing the whole menu. The occurs in both G.A.N.T. and MePo? themes for me with the GUI set to 1170x670 offset 60,16. This patch fixes this by using the rectangle returned by GetUIScreenRect() instead of the member screenRect.

[david.asher@…]

use zero oriented screen rect when not clipping

[david.asher@…]

It didn't use my email address. I know I put it there.

[David Asher <david.asher@…>]

second version of patch which only allocates the rectangle once

[David Asher <david.asher@…>]

It bugged me that my first patch was passing QRect's around by value so frequently, so I attached a second version of the patch which allocates a uiScreenRect to store the rectangle and uses it directly instead of calling GetUIScreenRect().

[stuartm]

(In [13603]) Applies patch from David Asher to handle repainting of the entire screen correctly when offsets are involved with the opengl driver.

For more information see #3385

Fixes #3385

[stuartm]

(In [13611]) Backports [13603] to -fixes.

Applies patch from David Asher to handle repainting of the entire screen correctly when offsets are involved with the opengl driver.

For more information see #3385

Refs #3385