Opened 13 years ago

Closed 13 years ago

#3429 closed patch (fixed)

Use recstartts for formatted names in Perl bindings

Reported by: sphery <mtdean@…> Owned by: xris
Priority: minor Milestone: unknown
Component: perl / nuvexport Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch, mythtv-perl_bindings-use_recstartts_for_formatted_names.patch , patches the Perl bindings to use recstartts (recording start time) for the formatted file names rather than using starttime (the scheduled program start time) (see, also, #3426). This means that rather than having multiple links/file with identical names save a "counter", we would actually create names appropriate for the recording file (i.e. 20070506-2004-2030-_The_Simpsons-_Crook_and_Ladder.mpg for my recording which started 4 minutes late due to technical issues and, had I had a crash during recording causing a 2nd part, I could have had 20070506-2012-2030-_The_Simpsons-_Crook_and_Ladder.mpg or something, also). Generally speaking, too, the counter (i.e. "-1" and "-2" is out of order, so -2 is often the first part of the show and -1 is the second. Therefore, I feel that just using recstartts for filenames--which will also cause them to be ordered properly--is appropriate.

If, however, removing the ability to use program start/end time (i.e. by forcing the use of recording start/end time) is not desired, let me know and I'll add an additional option like we have for endtime. My recommendation would be to use recording start time (recstartts) by default unless the user asks for program start time (starttime) (i.e. by prepending "p" to the appropriate time/date format code for recording start/end time).

However, I have a feeling allowing the user to specify program start time will cause many repeats of #3426, but--rather than reporting a real bug--these future tickets will be invalid tickets created due to user error/misunderstanding. Then again, always using recstartts is likely to cause many questions about why mythrename says the Simpsons started at 7:59 PM or something. Therefore, I'll defer the choice of which approach to take (force use of recstartts, default to recstartts but allow starttime, or default to starttime but allow recstartts) to the one who will close future invalid tickets.

Attachments (2)

mythtv-perl_bindings-use_recstartts_for_formatted_names.patch (775 bytes) - added by sphery <mtdean@…> 13 years ago.
mythtv-perl_bindings-use_recstartts_for_formatted_names_allow_starttime.patch (7.1 KB) - added by sphery <mtdean@…> 13 years ago.
Makes recstarts/recendts default, but allows user to specify program start/end times with "p" prefix (i.e. "%pi" for start minutes or "%pei" for end minutes). Either this patch or the previous should be applied (not both).

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by sphery <mtdean@…>

Changed 13 years ago by sphery <mtdean@…>

Makes recstarts/recendts default, but allows user to specify program start/end times with "p" prefix (i.e. "%pi" for start minutes or "%pei" for end minutes). Either this patch or the previous should be applied (not both).

comment:1 Changed 13 years ago by xris

(In [13488]) Apply sphery's patch to use recstartts instead of progstart for default time info in file renaming calls, re #3429

comment:2 Changed 13 years ago by xris

Resolution: fixed
Status: newclosed

(In [13489]) Apply sphery's patch to update instructions regarding use of recstartts instead of progstart for default time info in file renaming calls. closes #3429

Note: See TracTickets for help on using tickets.