Opened 12 years ago

Closed 12 years ago

#3442 closed enhancement (fixed)

Enable song information on changing visualizers

Reported by: anonymous Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I didn't like the fact that mythmusic shows only the type of visualizer at song beginning, when the "change the visualizer on each song" option is enabled. I added another option to let mythmusic show either the type of visualizer or the song information if this option is used. Default is to show the song information.

Attachments (2)

show_cycle_visualizer.patch (2.9 KB) - added by anonymous 12 years ago.
show_cycle_visualizer_2.patch (2.6 KB) - added by wilhelm.eger@… 12 years ago.
Updated patch. The first one was malformed.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by anonymous

Attachment: show_cycle_visualizer.patch added

Changed 12 years ago by wilhelm.eger@…

Updated patch. The first one was malformed.

comment:1 Changed 12 years ago by stuartm

Owner: changed from Isaac Richards to stuartm

I'd rather not add yet another setting. Instead we should just stop showing the visualiser name on automatic changes. I can only see a point in displaying it when you are manually cycling through the visualisers.

comment:2 Changed 12 years ago by wilhelm.eger@…

What about showing the song information _and_ the type of visualizer?

comment:3 Changed 12 years ago by stuartm

Would anyone fight for the name of the visualizer being shown on automatic changes? I really can't see the value.

comment:4 Changed 12 years ago by wilhelm.eger@…

This one?

void PlaybackBoxMusic::CycleVisualizer()
{
    // Only change the visualizer if there is more than 1 visualizer
    // and the user currently has a visualizer active
    if (visual_modes.count() > 1 && visualizer_status > 0)
    {
        if (random_visualizer)
        {
            unsigned int next_visualizer;

            //Find a visual thats not like the previous visual
            do
                next_visualizer = rand() % visual_modes.count();
            while (next_visualizer == current_visual);
            current_visual = next_visualizer;
        }
        else
        {
            //Change to the next selected visual
            current_visual = (current_visual + 1) % visual_modes.count();
        }

        //Change to the new visualizer
        visual_mode_timer->stop();
        mainvisual->setVisual("Blank");
        mainvisual->setVisual(visual_modes[current_visual]);
    }
    else if (visual_modes.count() == 1 && visual_modes[current_visual] == "AlbumArt" &&
             visualizer_status > 0)
    {
        // If only the AlbumArt visualization is selected, then go ahead and
        // restart the visualization.  This will give AlbumArt the opportunity
        // to change images if there are multiple images available.
        visual_mode_timer->stop();
        mainvisual->setVisual("Blank");
        mainvisual->setVisual(visual_modes[current_visual]);
    }
    if (show_cycle_visualizer)
    {
        bannerEnable(tr("Visualization: ") + visual_modes[current_visual], 4000);
    }
    else
    {
        bannerEnable(curMeta, show_album_art);
    }
}

comment:5 Changed 12 years ago by stuartm

Resolution: fixed
Status: newclosed

(In [13580]) Closes #3442

Don't show the visualisation name in the banner when changing it automatically.

Note: See TracTickets for help on using tickets.