Opened 13 years ago

Closed 13 years ago

#3462 closed defect (fixed)

Multi-stream OGM in Internal player causes frontend to crash

Reported by: Jo Shields <directhex@…> Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: mythvideo Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I have a collection of home-made DVD rips in OGM format:

directhex@mortos:/media/despair/Media/Video/Movies$ ogminfo Finding\ Nemo.ogm (ogminfo.c) (v1/serial 1) fps: 25.000 width height: 720x400 codec: 0x48323634 (H264) (ogminfo.c) (a1/serial 2) codec: 8192 (0x2000) (AC3) bits per sample: 2 channels: 6 samples per second: 48000 avgbytespersec: 56000 blockalign: 1536

Some of the videos (i.e. foreign films) contain multiple streams - the original audio, the dubbed audio, and subtitles for using with the original audio:

directhex@mortos:/media/despair/Media/Video/Movies$ ogminfo Kiki\'s\ Delivery\ Service.ogm (ogminfo.c) (v1/serial 0) fps: 25.000 width height: 720x400 codec: 0x48323634 (H264) (ogminfo.c) (a1/serial 1) codec: 8192 (0x2000) (AC3) bits per sample: 2 channels: 6 samples per second: 48000 avgbytespersec: 56000 blockalign: 1536 (ogminfo.c) (a2/serial 2) codec: 8192 (0x2000) (AC3) bits per sample: 2 channels: 6 samples per second: 48000 avgbytespersec: 48000 blockalign: 1536 (ogminfo.c) (t1/serial 3) text/subtitle stream

Whilst the former class of files play fine with the internal player, the latter class cause the frontend to crash the instant they start playing.

Attachments (4)

gdb.txt (23.5 KB) - added by Jo Shields <directhex@…> 13 years ago.
Backtrace for frontend crash during on multi-stream OGM playback
srtplayback.gdb (23.5 KB) - added by Jo Shields <directhex@…> 13 years ago.
GDB trace for same as before, with "-v playback"
srtplayback.log (8.2 KB) - added by Jo Shields <directhex@…> 13 years ago.
mythfrontend log for same as before - definitely seems to choke on SRT stream
afd_no_assert_on_unknown_video_codec.patch (799 bytes) - added by Anduin Withers 13 years ago.
Skips "video" streams with no codec id

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by Jo Shields <directhex@…>

Attachment: gdb.txt added

Backtrace for frontend crash during on multi-stream OGM playback

Changed 13 years ago by Jo Shields <directhex@…>

Attachment: srtplayback.gdb added

GDB trace for same as before, with "-v playback"

Changed 13 years ago by Jo Shields <directhex@…>

Attachment: srtplayback.log added

mythfrontend log for same as before - definitely seems to choke on SRT stream

comment:1 Changed 13 years ago by Jo Shields <directhex@…>

I uploaded a quick sample file to http://apebox.org/War3.ogm (~1.5M)

It appears to be dying on the text stream. ogminfo shows the file as having the following characteristics:

directhex@mortos:/tmp$ ogminfo War3.ogm
(ogminfo.c) (v1/serial 0) fps: 24.002 width height: 800x340 codec: 0x48323634 (H264)
(ogminfo.c) (a1/serial 1) codec: 85 (0x0055) (MP3) bits per sample: 0 channels: 2  samples per second: 44100 avgbytespersec: 16000 blockalign: 1152
(ogminfo.c) (t1/serial 2) text/subtitle stream

However, ffmpeg shows the following:

directhex@mortos:/tmp$ ffmpeg -i War3.ogm 2>&1 | grep Stream
  Stream #0.0: Video: h264, yuv420p, 800x340, 24.00 fps(r)
  Stream #0.1: Audio: mp3, 44100 Hz, stereo, 128 kb/s
  Stream #0.2: Video: 0x0000, 1000000.00 fps(r)

Note that ffmpeg shows the text stream as a video stream.

Changed 13 years ago by Anduin Withers

Skips "video" streams with no codec id

comment:2 Changed 13 years ago by Anduin Withers

(In [13500]) References #3462

Replaces an assert with a log message, a "video" stream with an unknown codec will no longer cause the frontend to exit.

comment:3 Changed 13 years ago by Anduin Withers

Resolution: fixed
Status: newclosed

(In [13504]) Closes #3462

Apply trunk [13500]

Original commit message:

Replaces an assert with a log message, a "video" stream with an unknown

codec will no longer cause the frontend to exit.

Note: See TracTickets for help on using tickets.