Opened 13 years ago

Closed 12 years ago

#3479 closed enhancement (fixed)

patch for separating aspect ratio override and zoom modes

Reported by: Petr Stehlik <pstehlik@…> Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The zoom.diff patch separates the aspect ratio overrides (4:3 or 16:9) and custom zoom modes intended for getting rid of the letterboxed black bars or for better use of 16:9 screen for 4:3 materials. Daniel suggested me to do this before implementing my 14:9 custom zoom mode some 11 months ago.

It was developed and tested on 0.20-fixes using the separate zoom-0.20-fixes.diff (apply the 0.20-fixes.diff to your 0.20-fixes tree first before applying the main zoom.diff patch) but the zoom.diff patch is naturally against svn trunk.

I tried to tripple-check everything so I hope it's correct. I tested it both on 4:3 and 16:9 screen with 4:3 and 16:9 material. The Half (14:9) and Full zoom modes work correctly but I am not sure about the Stretch mode. I don't see when it is to be used - I probably don't have proper source material for testing it. I suppose that the math in ApplyLetterboxing?() could be improved or simplified now (maybe I got mixed the original Fill and Stretch modes) but that can come in a separate patch later.

More intelligent "Fill" zoom mode can be added when automatic black bars detection is implemented, until that it's just guessing how much user wants to zoom in and I think the Half zoom is an useful addition (used by myself exclusively for watching 4:3 video on 16:9 display).

The "AdjustFill?" was used instead of more natural "Zoom" because there is another Zoom (a manual one) already and I wanted to avoid confusion in the source code. I wouldn't be surprised if some things were renamed by native speakers before commiting so I didn't modify any documentation or translation files yet.

I'd change the "W" key used for cycling between the aspect modes to toggle the new zoom mode instead but I didn't want to make it part of this patch because users in some countries still find the aspect override switch useful.

GUI setting in mythfrontend was separated as well but the Zoom selector was not enabled since it doesn't fit on the screen. And besides that it's not useful as a global option, I am afraid. Others suggested to make it part of playback groups or something so once this patch is accepted they can build on top of that...

Attachments (2)

zoom.diff (26.7 KB) - added by Petr Stehlik <pstehlik@…> 13 years ago.
separates aspect override and zoom modes
zoom-0.20-fixes.diff (2.6 KB) - added by Petr Stehlik <pstehlik@…> 13 years ago.
brings 0.20-fixes' zoom files to sync with svn trunk

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by Petr Stehlik <pstehlik@…>

Attachment: zoom.diff added

separates aspect override and zoom modes

Changed 13 years ago by Petr Stehlik <pstehlik@…>

Attachment: zoom-0.20-fixes.diff added

brings 0.20-fixes' zoom files to sync with svn trunk

comment:1 Changed 13 years ago by danielk

Milestone: unknown0.21
Owner: changed from Isaac Richards to danielk
Severity: mediumlow
Version: unknownhead

Cool, I'll have a look at this as soon as I get a chance.

comment:2 Changed 12 years ago by danielk

(In [14435]) Refs #3479. Applies zoom/aspect split patch from Petr Stehlik to mythtv-vid branch.

comment:3 Changed 12 years ago by danielk

Milestone: 0.21unknown
Type: patchenhancement

comment:4 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [14477]) Refs #2287. Fixes #1842. Fixes #3943. Fixes #3479. Merges mythtv-vid to svn trunk.

After the merge last week, I applied some patches that were waiting in the queue for mythtv-vid.

  • Fixes some issues with VIA CN400 drivers not displaying 1080i frames.
  • Adds a workaround to for crashes due to bugs in the Intel and VIA OpenGL drivers.
  • Allows OpenGL rendering to work with GLX 1.2 for ATI and Intel cards.
  • Seperates preconfigured zoom and aspect ratio override modes, "W" is still the binding for zoom, and "Ctrl-W" now overrides the aspect ratio specified in a video file.
  • Adds a new OpenGL video renderer output filter from Mark Kendall.
  • Reworks some of the OpenGL video renderer locking for greater stability.
Note: See TracTickets for help on using tickets.