Opened 13 years ago

Closed 12 years ago

#3522 closed defect (fixed)

Deleting a video doesn't delete the .png in the data directory

Reported by: anonymous Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I deleted a bunch of recorded videos today but when I looked in the video data directory I found that the backend had left behind a bunch of pngs for those deleted videos. From the #mythtv-users channel:

  • <xris> warlord: yeah. but I've never seen that happen
  • <xris> or not happen...
  • <warlord> It happened to me this morning
  • <warlord> using trunk/r13508
  • <xris> hmm, I actually do see a couple of stray png files in mine, too.
  • <xris> sounds like a bug

Attachments (1)

mythtv-spaces_in_png_filenames.patch (813 bytes) - added by sphery <mtdean@…> 12 years ago.
Allows mainserver to find all PNG's--even those with spaces or semicolons in the filename

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham

Are the png files for the recordings you deleted right then or for older recordings? Do the ownership and/or permissions on these png files differ from the settings on your other png files?

You may have had something like the following in your logs, can you supply the log output from when you deleted these recordings and the png files remained behind?

comment:2 Changed 12 years ago by Nick Morrott <<knowledgejunkie [at] gmail [dot] com>>

Running r14147, I noticed today that after running mythrename.pl on my recordings to be able to readily identify them, deleting them once they had been pulled off the box failed to delete any of the thumbnails, but did delete the recording.

Before renaming the files, I've not noticed any big problems with the thumbnails being automatically deleted. I have occasionally found stranded thumbnails, but haven't checked into it further.

Changed 12 years ago by sphery <mtdean@…>

Allows mainserver to find all PNG's--even those with spaces or semicolons in the filename

comment:3 Changed 12 years ago by sphery <mtdean@…>

Attached is a patch, mythtv-spaces_in_png_filenames.patch, which allows the code in mainserver.cpp to find all PNG previews associated with a recording even after the user renames the recording file with mythrename.pl and includes spaces or semicolons in the filename. I couldn't find any way to escape the spaces/semicolons in the namefilter for QDir, so I just replaced them with the ? (match any character wildcard).

comment:4 Changed 12 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [15397]) Allow MainServer::DoDeleteThread?() to find all .png files for a recording by replacing spaces and semicolons in the search spec with a question mark so that QDir can find them.

Closes #3522 using patch by Michael T. Dean. References #3779 and commit [15394] since that patch used the same logic in mythtranscode to rename png files.

Note: See TracTickets for help on using tickets.